unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Jonathan Brielmaier <jonathan.brielmaier@web.de>, guix-devel@gnu.org
Subject: Re: Pushed a fix (?) for ACL key location
Date: Sun, 12 Jul 2020 15:57:09 +0200	[thread overview]
Message-ID: <865zasbzuy.fsf@gmail.com> (raw)
In-Reply-To: <522d8a75-a2ba-d6a0-908f-a6e5029c3309@web.de>

Hi Jonathan,

On Sun, 12 Jul 2020 at 13:42, Jonathan Brielmaier <jonathan.brielmaier@web.de> wrote:

> As I ran into all those little errors with `guix pull` this week-end, I
> wonder if we can do better.
>
> So maybe some pre-checkin CI which tests that a commit/commit series
> doesn't break `guix pull`. What do you think? Is this doable?

Testing "guix pull" to detect earlier breakage is a recurring topic. :-)
Well, "make as-derivation" or almost equivalently"./pre-inst-env guix
pull -p /tmp/new" are the tools to do so.  But they require some CPU
time, so they are not always done before pushing.  And when it is
pushed, it is too late.

> I find those little errors pretty annoying as they seem to be avoidable
> through technical counter measures...

Even if the CI detects the failure, this will not prevent the end-user
for pulling something broken.  It is because the model: push directly to
master without any CI validation. Something is wrong with this model
when we speak about annoyance by little errors.

The end-user should (only) pull (by default) commits which pass the test
suite *and* where the substitutes are available.

Cheers,
simon



      parent reply	other threads:[~2020-07-12 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12  1:44 Pushed a fix (?) for ACL key location Christopher Lemmer Webber
2020-07-12 11:14 ` Marius Bakke
2020-07-12 11:42 ` Jonathan Brielmaier
2020-07-12 12:33   ` Marius Bakke
2020-07-12 14:21     ` zimoun
2020-07-12 16:27     ` Jonathan Brielmaier
2020-07-12 13:57   ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865zasbzuy.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=jonathan.brielmaier@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).