From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KJhHJcQWC1/sTAAA0tVLHw (envelope-from ) for ; Sun, 12 Jul 2020 13:57:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yJ4iIcQWC18VIwAA1q6Kng (envelope-from ) for ; Sun, 12 Jul 2020 13:57:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 336269400B1 for ; Sun, 12 Jul 2020 13:57:24 +0000 (UTC) Received: from localhost ([::1]:57264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jucTr-0006ME-1D for larch@yhetil.org; Sun, 12 Jul 2020 09:57:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jucTi-0006M0-N2 for guix-devel@gnu.org; Sun, 12 Jul 2020 09:57:14 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:46698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jucTh-0004WQ-6o for guix-devel@gnu.org; Sun, 12 Jul 2020 09:57:14 -0400 Received: by mail-wr1-x42e.google.com with SMTP id r12so10248955wrj.13 for ; Sun, 12 Jul 2020 06:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=/OCQTHb34T5nzMw7oKwfuKzkCdpqcjXl4YdPr/NrM+Y=; b=XdfdXurLmnr93Q8Lmqn2RrG3ftPKsXE/ITVRNkjNaSAdPXRTtduAq+W2j/3TWKbdrG nkbfDAHGRk0ffrHYxBK9iFhVKbxyjM3uATDF6zLkUYkbqzqjF9wgkLBvg1o/2bMF1Ua9 aHAjzY7pWGwT5g8Yr3ctLldvMGgmazdmfuYPxedFJC/6moeD32xAYWeZVYFhdL6Kywdb o1T6NmsKXzVxdkDULJx/GD+xgfoXF18ZRyAIHN41bTWFJM5f4NlvAnLts+IDr6En2tnW tiVlKZv7DrKkp8dIsrHHVCraiVAdYc5EDW+TsMUwfMDdpBWzz0cIeEB0EiYrPzfG0IiW Xb9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=/OCQTHb34T5nzMw7oKwfuKzkCdpqcjXl4YdPr/NrM+Y=; b=FVrYNhzpS4D/5wNefNROynmZUUWXK7+cc0QvtwociQSpueo2lNGTZY/45E3EMQYP3D BV87jx3hdB+t1Bma+nVW2n/VFYgEpr8rHa6/0x8fGierwCB7RUefH7KCC3X+9c+sNi6K QngKHpezJj7u6DTkmkqKQVgomFf7BrHz9UaLTYgr/dRjffAUSl/dtSrlD3rOmsz0/7zf 2Ewfup2FXgmlJQObL/vmEspxUMMqhYJrsyXd+JDJiYTWfU/mEA3Fr4tloGRedhOK/xVS BpVdhZZvDBPmk8H9CJJ6oK/ebBUUFTsCckue2MxuFzk9fpOwhxHk73M15jsV8J5r3DC7 8hTA== X-Gm-Message-State: AOAM533jqg42MWJiGnqcigGtQXJq6Cewkt39FsIetuVVgOFD0zd8uHjc fS0g/nY0KJzkBvO9WqJxI3TrRju1O9g= X-Google-Smtp-Source: ABdhPJxSjBhiD1PYBGT0vKssje9PraznpTX6/3cICVZnxyAxxV7y4qffl+DM3EA2TYrZ+wJXXheofg== X-Received: by 2002:adf:ec4e:: with SMTP id w14mr80106928wrn.280.1594562231480; Sun, 12 Jul 2020 06:57:11 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b186sm2455373wme.1.2020.07.12.06.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2020 06:57:10 -0700 (PDT) From: zimoun To: Jonathan Brielmaier , guix-devel@gnu.org Subject: Re: Pushed a fix (?) for ACL key location In-Reply-To: <522d8a75-a2ba-d6a0-908f-a6e5029c3309@web.de> References: <877dv98q1z.fsf@dustycloud.org> <522d8a75-a2ba-d6a0-908f-a6e5029c3309@web.de> Date: Sun, 12 Jul 2020 15:57:09 +0200 Message-ID: <865zasbzuy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=XdfdXurL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: 8XxLCIo8pU+L Hi Jonathan, On Sun, 12 Jul 2020 at 13:42, Jonathan Brielmaier wrote: > As I ran into all those little errors with `guix pull` this week-end, I > wonder if we can do better. > > So maybe some pre-checkin CI which tests that a commit/commit series > doesn't break `guix pull`. What do you think? Is this doable? Testing "guix pull" to detect earlier breakage is a recurring topic. :-) Well, "make as-derivation" or almost equivalently"./pre-inst-env guix pull -p /tmp/new" are the tools to do so. But they require some CPU time, so they are not always done before pushing. And when it is pushed, it is too late. > I find those little errors pretty annoying as they seem to be avoidable > through technical counter measures... Even if the CI detects the failure, this will not prevent the end-user for pulling something broken. It is because the model: push directly to master without any CI validation. Something is wrong with this model when we speak about annoyance by little errors. The end-user should (only) pull (by default) commits which pass the test suite *and* where the substitutes are available. Cheers, simon