From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [Patch v2] daemon: Set ownership of kept build directories to the calling user.
Date: Mon, 5 Dec 2016 21:51:51 +0100 [thread overview]
Message-ID: <5a0a09c4-3ace-550e-545a-3a7071baee4f@crazy-compilers.com> (raw)
In-Reply-To: <20161201010110.2325efc9@scratchpost.org>
Am 01.12.2016 um 01:01 schrieb Danny Milosavljevic:
> So I'd say to compare with (uid_t)-1 would be fine
>
> if (settings.clientUid != (uid_t) -1) {
> ...
> }
Thanks for this tip, Danny. This made it work and I just posted the
updated patch.
> > And casting uid_t to unisgned int might return the same uid as "nobody".
> [...]
>
> (-1) in two-complement 16 bit integral encoding (which is technically not guaranteed to be used in C) would be 65535.
Ahh, well, yes. I'm not quite good on bit operations, esp. on
representations of negative numbers. Thanks to doing this right.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2016-12-05 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 11:30 [Patch v2] daemon: Set ownership of kept build directories to the calling user Hartmut Goebel
2016-11-21 14:13 ` Ludovic Courtès
2016-11-21 14:18 ` Hartmut Goebel
2016-11-27 21:04 ` Ludovic Courtès
2016-11-28 21:31 ` Hartmut Goebel
2016-12-01 0:01 ` Danny Milosavljevic
2016-12-05 20:46 ` [PATCH v3] " Hartmut Goebel
2016-12-06 15:08 ` Ludovic Courtès
2016-12-08 12:12 ` Hartmut Goebel
2016-12-08 12:14 ` [PATCH v4] " Hartmut Goebel
2016-12-09 14:23 ` Ludovic Courtès
2016-12-09 14:47 ` Hartmut Goebel
2016-12-09 14:22 ` [PATCH v3] " Ludovic Courtès
2016-12-09 15:50 ` Guile-SSH found at configure-time but not at run-time Hartmut Goebel
2016-12-09 20:35 ` Ludovic Courtès
2016-12-06 20:41 ` [PATCH v3] daemon: Set ownership of kept build directories to the calling user Danny Milosavljevic
2016-12-08 12:16 ` Hartmut Goebel
2016-12-05 20:51 ` Hartmut Goebel [this message]
2016-11-21 17:36 ` [Patch v2] " Hartmut Goebel
2016-11-21 18:29 ` Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a0a09c4-3ace-550e-545a-3a7071baee4f@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).