unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [Patch v2] daemon: Set ownership of kept build directories to the calling user.
Date: Mon, 21 Nov 2016 19:29:40 +0100	[thread overview]
Message-ID: <58333D14.8030801@crazy-compilers.com> (raw)
In-Reply-To: <87shqkvs3a.fsf@gnu.org>

Am 21.11.2016 um 15:13 schrieb Ludovic Courtès:
> Could we instead pass them via the ‘LocalStore’ constructor,

I started implementing this, but adding clientUid/Gid as a attribute
(property) of 'LocalStore' feels wrong. The LocalStore is about the
store: files being there, querying and such. Even "build" is a bit of a
misfit IMO.

Okay, probably you mean, passing to the ‘LocalStore’ constructor and
then forward them to the goals. Which means changing
`makeDerevationGoal', which is used quite some time. From there you
would need to pass it onto the 'DerivationGoal' constructor. These are
quite some changes for the rare case of building, and only if the build
failed and only if the user passed --keep-failed.

I have the impression, that 'Settings' have been introduced exactly to
save passing around such information. "keep-failed" is passed to
'deleteTmpDir()' exactly this way (via Settings). Which means if passing
clientUid/Gid via constructors,  we would have two different ways of
passing information used in the same small function - which would be
inconsistent.

Thus said, I'm in strong favour of using Settings.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

      parent reply	other threads:[~2016-11-21 18:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 11:30 [Patch v2] daemon: Set ownership of kept build directories to the calling user Hartmut Goebel
2016-11-21 14:13 ` Ludovic Courtès
2016-11-21 14:18   ` Hartmut Goebel
2016-11-27 21:04     ` Ludovic Courtès
2016-11-28 21:31       ` Hartmut Goebel
2016-12-01  0:01         ` Danny Milosavljevic
2016-12-05 20:46           ` [PATCH v3] " Hartmut Goebel
2016-12-06 15:08             ` Ludovic Courtès
2016-12-08 12:12               ` Hartmut Goebel
2016-12-08 12:14                 ` [PATCH v4] " Hartmut Goebel
2016-12-09 14:23                   ` Ludovic Courtès
2016-12-09 14:47                     ` Hartmut Goebel
2016-12-09 14:22                 ` [PATCH v3] " Ludovic Courtès
2016-12-09 15:50                   ` Guile-SSH found at configure-time but not at run-time Hartmut Goebel
2016-12-09 20:35                     ` Ludovic Courtès
2016-12-06 20:41             ` [PATCH v3] daemon: Set ownership of kept build directories to the calling user Danny Milosavljevic
2016-12-08 12:16               ` Hartmut Goebel
2016-12-05 20:51           ` [Patch v2] " Hartmut Goebel
2016-11-21 17:36   ` Hartmut Goebel
2016-11-21 18:29   ` Hartmut Goebel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58333D14.8030801@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).