From: Andy Patterson <ajpatter@uwaterloo.ca>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] scripts: substitute: Avoid infinite looping when updating the substitute list
Date: Mon, 6 Jul 2015 20:08:52 -0400 [thread overview]
Message-ID: <559B1894.7090701@uwaterloo.ca> (raw)
In-Reply-To: <873810q3yr.fsf@gnu.org>
Hi Ludo,
> Did you observe the problem when connecting to hydra.gnu.org, or was it
> another server? Did you have a way to reproduce it?
I was only connecting to hydra.gnu.org, and was using a default setup.
First I used the install image, and then on my current setup with a
version built from git. I was always able to reproduce the problem. I
think it may be that the network setup where I live is causing the
connection to always be closed, as it seems that no-one else has
experienced it.
> I’ve committed a slightly edited version of the patch where I factorized
> the call to PROC and changed the commit message to describe the changes
> at the source code level, in GNU change log style. (I hope this is fine
> with you.)
That's good, thanks! I wasn't too sure on the specifics of the GNU style
and mostly tried to imitate examples from the recent history. Seeing
what you've changed gives me a better idea of the correct style.
Cheers,
Andy
next prev parent reply other threads:[~2015-07-07 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 0:21 [PATCH] scripts: substitute: Avoid infinite looping when updating the substitute list Andy Patterson
2015-07-06 23:08 ` Ludovic Courtès
2015-07-07 0:08 ` Andy Patterson [this message]
2015-07-07 14:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B1894.7090701@uwaterloo.ca \
--to=ajpatter@uwaterloo.ca \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).