From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Patterson Subject: Re: [PATCH] scripts: substitute: Avoid infinite looping when updating the substitute list Date: Mon, 6 Jul 2015 20:08:52 -0400 Message-ID: <559B1894.7090701@uwaterloo.ca> References: <5599C9F2.4080207@uwaterloo.ca> <873810q3yr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCGQc-0006u5-H5 for guix-devel@gnu.org; Mon, 06 Jul 2015 20:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCGQb-0006bU-Kq for guix-devel@gnu.org; Mon, 06 Jul 2015 20:08:02 -0400 In-Reply-To: <873810q3yr.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel@gnu.org Hi Ludo, > Did you observe the problem when connecting to hydra.gnu.org, or was it > another server? Did you have a way to reproduce it? I was only connecting to hydra.gnu.org, and was using a default setup. First I used the install image, and then on my current setup with a version built from git. I was always able to reproduce the problem. I think it may be that the network setup where I live is causing the connection to always be closed, as it seems that no-one else has experienced it. > I=E2=80=99ve committed a slightly edited version of the patch where I f= actorized > the call to PROC and changed the commit message to describe the changes > at the source code level, in GNU change log style. (I hope this is fin= e > with you.) That's good, thanks! I wasn't too sure on the specifics of the GNU style and mostly tried to imitate examples from the recent history. Seeing what you've changed gives me a better idea of the correct style. Cheers, Andy