From: Cyril Roelandt <tipecaml@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/6] gnu: Add libpeas.
Date: Sun, 01 Dec 2013 04:45:55 +0100 [thread overview]
Message-ID: <529AB0F3.1070005@gmail.com> (raw)
In-Reply-To: <87y545wnqo.fsf@gnu.org>
On 11/30/2013 11:03 PM, Ludovic Courtès wrote:
> Cyril Roelandt <tipecaml@gmail.com> skribis:
>
>> * gnu/packages/gnome.scm (libpeas): New variable.
>
> OK!
>
>> + (lambda* (#:key inputs #:allow-other-keys #:rest args)
>> + (let ((configure (assoc-ref %standard-phases 'configure))
>> + (gir-path (lambda (pkg-name)
>> + (string-append
>> + (assoc-ref inputs pkg-name)
>> + "/share/gir-1.0"))))
>> + (substitute* "libpeas-gtk/Makefile.in"
>> + (("--add-include-path")
>> + (string-append
>> + " --add-include-path=" (gir-path "atk")
>> + " --add-include-path=" (gir-path "gdk-pixbuf")
>> + " --add-include-path=" (gir-path "gtk+")
>> + " --add-include-path=" (gir-path "pango")
>> + " --add-include-path")))
>
> If this ‘gir-path’ thing is frequent, we should factorize it in a
> build-side module, say (guix build gnome). WDYT?
>
> (That shouldn’t block this particular patch, though.)
>
Yes, I think that every package using gobject-introspection will need a
gir-path method. I guess I could implement it in (guix build gnome) in
this patch.
Cyril.
next prev parent reply other threads:[~2013-12-01 3:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 1:13 [PATCH 0/6] Add eog Cyril Roelandt
2013-11-30 1:13 ` [PATCH 1/6] gnu: gobject-introspection: look for 'gcc' when no compiler seems available Cyril Roelandt
2013-11-30 21:59 ` Ludovic Courtès
2013-12-01 3:15 ` Cyril Roelandt
2013-12-01 22:11 ` Ludovic Courtès
2013-11-30 1:13 ` [PATCH 2/6] gnu: gtk+: enable introspection Cyril Roelandt
2013-11-30 22:01 ` Ludovic Courtès
2013-12-01 3:43 ` Cyril Roelandt
2013-12-01 22:12 ` Ludovic Courtès
2013-12-07 15:11 ` Cyril Roelandt
2013-12-07 15:27 ` Ludovic Courtès
2013-12-08 20:32 ` [PATCH 2/6 v2] " Cyril Roelandt
2013-12-08 23:53 ` Ludovic Courtès
2013-12-10 23:43 ` [PATCH 2/6 v3] " Cyril Roelandt
2013-12-11 21:09 ` Ludovic Courtès
2013-11-30 1:13 ` [PATCH 3/6] gnu: Add libpeas Cyril Roelandt
2013-11-30 22:03 ` Ludovic Courtès
2013-12-01 3:45 ` Cyril Roelandt [this message]
2013-12-01 22:13 ` Ludovic Courtès
2013-12-08 20:33 ` [PATCH 3/6 v2] " Cyril Roelandt
2013-12-08 23:55 ` Ludovic Courtès
2013-12-10 23:44 ` [PATCH 3/6 v6] " Cyril Roelandt
2013-12-11 21:10 ` Ludovic Courtès
2013-11-30 1:13 ` [PATCH 4/6] gnu: Add iso-codes Cyril Roelandt
2013-11-30 22:05 ` Ludovic Courtès
2013-12-01 3:47 ` Cyril Roelandt
2013-12-01 22:13 ` Ludovic Courtès
2013-12-08 20:33 ` [PATCH 4/6 v2] " Cyril Roelandt
2013-12-08 23:55 ` Ludovic Courtès
2013-11-30 1:13 ` [PATCH 5/6] gnu: Add gnome-desktop Cyril Roelandt
2013-11-30 22:07 ` Ludovic Courtès
2013-12-08 20:34 ` [PATCH 5/6 v2] " Cyril Roelandt
2013-12-08 23:57 ` Ludovic Courtès
2013-12-09 0:06 ` Cyril Roelandt
2013-12-09 17:34 ` Ludovic Courtès
2013-12-10 23:44 ` [PATCH 5/6 v3] " Cyril Roelandt
2013-12-11 21:11 ` Ludovic Courtès
2013-12-12 6:07 ` John Darrington
2013-12-12 21:22 ` Ludovic Courtès
2013-11-30 1:13 ` [PATCH 6/6] gnu: Add eog Cyril Roelandt
2013-11-30 22:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529AB0F3.1070005@gmail.com \
--to=tipecaml@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).