From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH 3/6] gnu: Add libpeas.
Date: Sun, 01 Dec 2013 04:45:55 +0100
Message-ID: <529AB0F3.1070005@gmail.com>
References: <1385774016-1418-1-git-send-email-tipecaml@gmail.com>
	<1385774016-1418-4-git-send-email-tipecaml@gmail.com>
	<87y545wnqo.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1Vmxy8-0004eh-8U
	for guix-devel@gnu.org; Sat, 30 Nov 2013 22:45:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1Vmxy2-0006Dl-Iv
	for guix-devel@gnu.org; Sat, 30 Nov 2013 22:45:16 -0500
In-Reply-To: <87y545wnqo.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On 11/30/2013 11:03 PM, Ludovic Courtès wrote:
> Cyril Roelandt <tipecaml@gmail.com> skribis:
>
>> * gnu/packages/gnome.scm (libpeas): New variable.
>
> OK!
>
>> +         (lambda* (#:key inputs #:allow-other-keys #:rest args)
>> +          (let ((configure (assoc-ref %standard-phases 'configure))
>> +                (gir-path (lambda (pkg-name)
>> +                           (string-append
>> +                            (assoc-ref inputs pkg-name)
>> +                            "/share/gir-1.0"))))
>> +           (substitute* "libpeas-gtk/Makefile.in"
>> +            (("--add-include-path")
>> +             (string-append
>> +               " --add-include-path=" (gir-path "atk")
>> +               " --add-include-path=" (gir-path "gdk-pixbuf")
>> +               " --add-include-path=" (gir-path "gtk+")
>> +               " --add-include-path=" (gir-path "pango")
>> +              " --add-include-path")))
>
> If this ‘gir-path’ thing is frequent, we should factorize it in a
> build-side module, say (guix build gnome).  WDYT?
>
> (That shouldn’t block this particular patch, though.)
>

Yes, I think that every package using gobject-introspection will need a 
gir-path method. I guess I could implement it in (guix build gnome) in 
this patch.


Cyril.