unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Raghav Gururajan" via "Development of GNU Guix and the GNU System distribution." <guix-devel@gnu.org>
To: "Bengt Richter" <bokr@bokr.com>, "Christopher Baines" <mail@cbaines.net>
Cc: guix-devel@gnu.org, Ryan Prior <ryanprior@hey.com>
Subject: Re: Questionable "cosmetic changes" commits
Date: Sun, 20 Dec 2020 07:07:03 +0000	[thread overview]
Message-ID: <4b50b929d38fcaae7577afce3e72616a@disroot.org> (raw)
In-Reply-To: <20201205234251.GA16129@LionPure>

Hi Bengt!

> ┌──────────────────────────────┐
> │ "So I removed the comments." │
> └──────────────────────────────┘
> Raghav, I think you may not grok the social signalling of a statement like that :)

My apologies! I didn't mean that with a negative connotation.

> It sounds like you are overlooking the _social_ need for consensus
> in modifying a shared environment.
> 
> Taking a picture off the wall of a shared living room is different
> from taking the same picture off the wall in your private room.
> 
> A git commit in a jointly developed FLOSS project is modifying a shared living room.
> (But do what you like in your own git repo ;-)
> 
> The social aspect is not about the technical merits of of your changes,
> it's about the difference between joint ownership and private ownership,
> and the differences in exercising owner rights.

I understand. When the patch was in the mail-list for a while, I assumed folks were okay with the changes. I am glad that Mark shared the concerns. This gave me an opportunity to be in consensus with others. :-)

I will be changing my work-flow to prevent this issue from happening again.

Regards,
RG.


  parent reply	other threads:[~2020-12-20  7:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 18:55 Questionable "cosmetic changes" commits Mark H Weaver
2020-12-02 20:13 ` Ryan Prior
2020-12-02 21:27   ` Tobias Geerinckx-Rice
2020-12-02 22:22   ` Mark H Weaver
2020-12-03  3:16   ` Bengt Richter
2020-12-02 21:33 ` Hartmut Goebel
2020-12-04  2:08 ` Raghav Gururajan
2020-12-04  3:30   ` Ryan Prior
2020-12-04  3:58     ` Raghav Gururajan
2020-12-04 15:12       ` Danny Milosavljevic
2020-12-05  6:47       ` Mark H Weaver
2020-12-05  7:06         ` Mark H Weaver
2020-12-05 20:37       ` Raghav Gururajan
2020-12-05 21:54         ` Christopher Baines
2020-12-05 23:42           ` Bengt Richter
2020-12-20  7:07           ` Raghav Gururajan via Development of GNU Guix and the GNU System distribution. [this message]
2020-12-05 23:29         ` Cosmetic changes commits as a potential security risk (was Re: Questionable "cosmetic changes" commits) Mark H Weaver
2020-12-20  6:55         ` Questionable "cosmetic changes" commits Raghav Gururajan via Development of GNU Guix and the GNU System distribution.
2020-12-20  7:00         ` Cosmetic changes commits as a potential security risk (was Re: Questionable "cosmetic changes" commits) Raghav Gururajan via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b50b929d38fcaae7577afce3e72616a@disroot.org \
    --to=guix-devel@gnu.org \
    --cc=bokr@bokr.com \
    --cc=mail@cbaines.net \
    --cc=raghavgururajan@disroot.org \
    --cc=ryanprior@hey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).