[PATCH] gnu: services: Activate system prior to services

[PATCH] gnu: services: Activate system prior to services

[Christopher Baines]

This patch fixes some issues I've had with the postgresql service and database
locales. If system activation takes place before service activation, the
locales are present and PostgreSQL can use them, but otherwise the PostgreSQL
service is limited in the locales that can be used.

[PATCH] gnu: services: Activate system prior to services

[Christopher Baines]

* gnu/services.scm: Activate the current system prior to the services,
  as this allows the services to use the files from the system, for
  example locales, in the service activation process.
---
 gnu/services.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/services.scm b/gnu/services.scm
index 693a7f8..5d2789c 100644
--- a/gnu/services.scm
+++ b/gnu/services.scm
@@ -338,12 +338,12 @@ ACTIVATION-SCRIPT-TYPE."
                       (activate-/bin/sh
                        (string-append #$(canonical-package bash) "/bin/sh"))
 
+                      ;; Set up /run/current-system.
+                      (activate-current-system)
+
                       ;; Run the services' activation snippets.
                       ;; TODO: Use 'load-compiled'.
-                      (for-each primitive-load '#$actions)
-
-                      ;; Set up /run/current-system.
-                      (activate-current-system))))))
+                      (for-each primitive-load '#$actions))))))
 
 (define (gexps->activation-gexp gexps)
   "Return a gexp that runs the activation script containing GEXPS."
-- 
2.10.2

Re: [PATCH] gnu: services: Activate system prior to services

[Ludovic Courtès]

Hello!

Christopher Baines <mail@cbaines.net> skribis:

> This patch fixes some issues I've had with the postgresql service and database
> locales. If system activation takes place before service activation, the
> locales are present and PostgreSQL can use them, but otherwise the PostgreSQL
> service is limited in the locales that can be used.

Oh, so “initdb” used to be run under the C locale, right?

> * gnu/services.scm: Activate the current system prior to the services,
>   as this allows the services to use the files from the system, for
>   example locales, in the service activation process.

I’ve added part of this justification as a comment in the code and
tweaked the commit log.

Pushed, thanks!

Ludo’.

Re: [PATCH] gnu: services: Activate system prior to services

[Christopher Baines]

On 11/12/16 09:01, Ludovic Courtès wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>> This patch fixes some issues I've had with the postgresql service and database
>> locales. If system activation takes place before service activation, the
>> locales are present and PostgreSQL can use them, but otherwise the PostgreSQL
>> service is limited in the locales that can be used.
>
> Oh, so “initdb” used to be run under the C locale, right?

Something like that, I don't remember the exact details.

>> * gnu/services.scm: Activate the current system prior to the services,
>>   as this allows the services to use the files from the system, for
>>   example locales, in the service activation process.
>
> I’ve added part of this justification as a comment in the code and
> tweaked the commit log.
>
> Pushed, thanks!

Great, thanks :)