Re: [PATCH] gnu: Add hdf4

[Eric Bavier <ericbavier@openmailbox.org>]

On 2016-05-29 17:07, ludo@gnu.org wrote:
> Hello,
> 
> Jeremy Robst <jpro@bas.ac.uk> skribis:
> 
>> Here's the patch as an attachment - sorry for the hassle. I will try
>> and work out what's going wrong so I can send proper patches in
>> future.
> 
> No problem!
> 
> I tried the attached patch, which includes mostly cosmetic changes
> compared to the one you posted.  However, I stumble upon test failures
> (on x86_64, with Linux-libre 4.6.0):
> 
> --8<---------------cut here---------------start------------->8---
> ----------------------------
> hdftest  Test Log
> ----------------------------
> Testing create/read/write compressed datasets (tcomp.c)                
> PASSED
> Testing create/read/write chunked datasets (tchunk.c)                  
> PASSED
> Testing reading of netCDF file using the SDxxx inteface (tnetcdf.c)    
> PASSED
> Testing functionality of dimensions (tdim.c)                           
> PASSED
> Testing functions involving empty data sets (temptySDSs.c)             
> PASSED
> Testing various setting attribute features (tattributes.c)             
> PASSED
> Testing getting data size of special data (tdatasizes.c)               
> PASSED
> Testing getting location info of data (tdatainfo.c)                    
> PASSED
> Testing getting location info of attr and annot data (tattdatainfo.c)  
> PASSED
> Testing a mix of SD, V, and VS functions (tmixed_apis.c)               
> PASSED
> Testing miscellaneous file related functions (tfile.c)
> *** Routine test_maxopenfiles: SDstart FAILED at line 285 ***
> *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 ***
> SDgetfilename: incorrect file being opened - expected <file5>, 
> retrieved <file4>
> *** Routine test_maxopenfiles: SDend FAILED at line 305 ***
> Testing various SDS' properties (tsdsprops.c)                          
> PASSED
> Testing various coordinate variable features (tcoordvar.c)             
> PASSED
> Testing szip compression for datasets (tszip.c)                        
> PASSED
> *** HDF-SD test fails ***
> Makefile:1169: recipe for target 'hdftest.chkexe_' failed
> make[5]: *** [hdftest.chkexe_] Error 1
> make[5]: *** Waiting for unfinished jobs....
> Finished testing testmfhdf.sh
> ============================
> testmfhdf.sh  Test Log
> ============================
> =============================
> Running mfhdf tests
> =============================
> =============================
> HDF-SD C interface tests
> =============================
> Testing create/read/write compressed datasets (tcomp.c)                
> PASSED
> Testing create/read/write chunked datasets (tchunk.c)                  
> PASSED
> Testing reading of netCDF file using the SDxxx inteface (tnetcdf.c)    
> PASSED
> Testing functionality of dimensions (tdim.c)                           
> PASSED
> Testing functions involving empty data sets (temptySDSs.c)             
> PASSED
> Testing various setting attribute features (tattributes.c)             
> PASSED
> Testing getting data size of special data (tdatasizes.c)               
> PASSED
> Testing getting location info of data (tdatainfo.c)                    
> PASSED
> Testing getting location info of attr and annot data (tattdatainfo.c)  
> PASSED
> Testing a mix of SD, V, and VS functions (tmixed_apis.c)               
> PASSED
> Testing miscellaneous file related functions (tfile.c)
> *** Routine test_maxopenfiles: SDstart FAILED at line 285 ***
> *** Routine test_maxopenfiles: SDstart FAILED at line 285 ***
> *** Routine test_maxopenfiles: SDstart FAILED at line 285 ***
> 
> [...]
> 
> SDgetfilename: incorrect file being opened - expected <file67>,
> retrieved <file57>
> *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 ***
> SDgetfilename: incorrect file being opened - expected <file68>,
> retrieved <file57>
> *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 ***
> SDgetfilename: incorrect file being opened - expected <file69>,
> retrieved <file57>
> *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 ***
> --8<---------------cut here---------------start------------->8---
> 
> Any ideas?

I get the same failures intermittently.  Other times the build passes.

Also, I've verified that the part of the patch that touches 
libhdf4.settings.in is not required for build reproducibility.

-- 
`~Eric