From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: Add hdf4 Date: Thu, 02 Jun 2016 09:43:43 -0500 Message-ID: <22481a77dcf5733b4547f9ecf1a390a3@openmailbox.org> References: <20160523181719.GA11083@jasmine> <20160527171933.GA29109@jasmine> <87k2iel0bo.fsf@gnu.org> <87shx0tt5e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8TrO-00077z-RE for guix-devel@gnu.org; Thu, 02 Jun 2016 10:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8TrL-0006uI-9g for guix-devel@gnu.org; Thu, 02 Jun 2016 10:44:34 -0400 In-Reply-To: <87shx0tt5e.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ludo@gnu.org Cc: guix-devel@gnu.org, Guix-devel On 2016-05-29 17:07, ludo@gnu.org wrote: > Hello, > > Jeremy Robst skribis: > >> Here's the patch as an attachment - sorry for the hassle. I will try >> and work out what's going wrong so I can send proper patches in >> future. > > No problem! > > I tried the attached patch, which includes mostly cosmetic changes > compared to the one you posted. However, I stumble upon test failures > (on x86_64, with Linux-libre 4.6.0): > > --8<---------------cut here---------------start------------->8--- > ---------------------------- > hdftest Test Log > ---------------------------- > Testing create/read/write compressed datasets (tcomp.c) > PASSED > Testing create/read/write chunked datasets (tchunk.c) > PASSED > Testing reading of netCDF file using the SDxxx inteface (tnetcdf.c) > PASSED > Testing functionality of dimensions (tdim.c) > PASSED > Testing functions involving empty data sets (temptySDSs.c) > PASSED > Testing various setting attribute features (tattributes.c) > PASSED > Testing getting data size of special data (tdatasizes.c) > PASSED > Testing getting location info of data (tdatainfo.c) > PASSED > Testing getting location info of attr and annot data (tattdatainfo.c) > PASSED > Testing a mix of SD, V, and VS functions (tmixed_apis.c) > PASSED > Testing miscellaneous file related functions (tfile.c) > *** Routine test_maxopenfiles: SDstart FAILED at line 285 *** > *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 *** > SDgetfilename: incorrect file being opened - expected , > retrieved > *** Routine test_maxopenfiles: SDend FAILED at line 305 *** > Testing various SDS' properties (tsdsprops.c) > PASSED > Testing various coordinate variable features (tcoordvar.c) > PASSED > Testing szip compression for datasets (tszip.c) > PASSED > *** HDF-SD test fails *** > Makefile:1169: recipe for target 'hdftest.chkexe_' failed > make[5]: *** [hdftest.chkexe_] Error 1 > make[5]: *** Waiting for unfinished jobs.... > Finished testing testmfhdf.sh > ============================ > testmfhdf.sh Test Log > ============================ > ============================= > Running mfhdf tests > ============================= > ============================= > HDF-SD C interface tests > ============================= > Testing create/read/write compressed datasets (tcomp.c) > PASSED > Testing create/read/write chunked datasets (tchunk.c) > PASSED > Testing reading of netCDF file using the SDxxx inteface (tnetcdf.c) > PASSED > Testing functionality of dimensions (tdim.c) > PASSED > Testing functions involving empty data sets (temptySDSs.c) > PASSED > Testing various setting attribute features (tattributes.c) > PASSED > Testing getting data size of special data (tdatasizes.c) > PASSED > Testing getting location info of data (tdatainfo.c) > PASSED > Testing getting location info of attr and annot data (tattdatainfo.c) > PASSED > Testing a mix of SD, V, and VS functions (tmixed_apis.c) > PASSED > Testing miscellaneous file related functions (tfile.c) > *** Routine test_maxopenfiles: SDstart FAILED at line 285 *** > *** Routine test_maxopenfiles: SDstart FAILED at line 285 *** > *** Routine test_maxopenfiles: SDstart FAILED at line 285 *** > > [...] > > SDgetfilename: incorrect file being opened - expected , > retrieved > *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 *** > SDgetfilename: incorrect file being opened - expected , > retrieved > *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 *** > SDgetfilename: incorrect file being opened - expected , > retrieved > *** Routine test_maxopenfiles: SDgetfilename FAILED at line 292 *** > --8<---------------cut here---------------start------------->8--- > > Any ideas? I get the same failures intermittently. Other times the build passes. Also, I've verified that the part of the patch that touches libhdf4.settings.in is not required for build reproducibility. -- `~Eric