Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Mark H Weaver]

Hi Roel,

roel@gnu.org (Roel Janssen) writes:

> roelj pushed a commit to branch master
> in repository guix.
>
> commit d5456444f7032e7bc9168db2b59e548672795b72
> Author: Roel Janssen <roel@gnu.org>
> Date:   Thu Jan 4 00:46:32 2018 +0100
>
>     gnu: vlc: Enable libdvdread and libdvdcss support.
>     
>     * gnu/packages/video.scm (libdvdread): Compile with libdvdcss support;
>       (vlc): Add libdvdread as input.

This commit broke 'gnome-disk-utility', which has 'libdvdread' as an
input.  Since 'gnome-disk-utility' is an input to the 'gnome' package,
it breaks every system that uses 'gnome-desktop-service'.

Therefore, I reverted this commit for now.

Here's the tail of the failed 'gnome-disk-utility' build log:

--8<---------------cut here---------------start------------->8---
starting phase `configure'
The Meson build system
Version: 0.42.1
Source dir: /tmp/guix-build-gnome-disk-utility-3.26.2.drv-0/gnome-disk-utility-3.26.2
Build dir: /tmp/guix-build-gnome-disk-utility-3.26.2.drv-0/build
Build type: native build
Project name: gnome-disk-utility
Native C compiler: gcc (gcc 5.4.0)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Has header "dlfcn.h": YES
Has header "inttypes.h": YES
Has header "memory.h": YES
Has header "stdint.h": YES
Has header "stdlib.h": YES
Has header "strings.h": YES
Has header "string.h": YES
Has header "sys/stat.h": YES
Has header "sys/types.h": YES
Has header "unistd.h": YES
Checking for function "dcgettext": YES
Checking for function "gettext": YES
Checking for function "iconv": YES
Checking for function "memset": YES
Checking for function "setlocale": YES
Checking for function "strstr": YES
Message: Checking for valid fallocate() function
Found pkg-config: /gnu/store/r9pi4am4m9wyds25rjx9hl35dz0mfny9-pkg-config-0.29.2/bin/pkg-config (0.29.2)
Native dependency gmodule-2.0 found: YES 2.52.3
Native dependency gio-unix-2.0 found: YES 2.52.3
Native dependency udisks2 found: YES 2.1.8
Native dependency gtk+-3.0 found: YES 3.22.21
Native dependency libsecret-1 found: YES 0.18.5
Native dependency pwquality found: YES 1.4.0
Native dependency libcanberra-gtk3 found: YES 0.30

Meson encountered an error in file meson.build, line 158, column 0:
Could not generate cargs for dvdread:


phase `configure' failed after 2.4 seconds
note: keeping build directory `/tmp/guix-build-gnome-disk-utility-3.26.2.drv-0'
builder for `/gnu/store/xzwf0jlsrvgsd9mjfrg3iijchjip1vh3-gnome-disk-utility-3.26.2.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

Would you like to investigate?

     Regards,
       Mark

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Danny Milosavljevic]

Hi Mark,

thanks for the heads-up!

The fix would be in our libdvdread:

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e64c1e089..e46ec15f8 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1365,7 +1365,7 @@ players, like VLC or MPlayer.")
      `(#:configure-flags '("--with-libdvdcss=yes")))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
-    (inputs
+    (propagated-inputs
      `(("libdvdcss" ,libdvdcss)))
     (description
      "Libdvdread provides a simple foundation for reading DVD video

... because dvdread.pc Requires.private libdvdcss.

Not sure what's up with meson's unhelpful error message...

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Roel Janssen]

Danny Milosavljevic writes:

> Hi Mark,
>
> thanks for the heads-up!
>
> The fix would be in our libdvdread:
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index e64c1e089..e46ec15f8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1365,7 +1365,7 @@ players, like VLC or MPlayer.")
>       `(#:configure-flags '("--with-libdvdcss=yes")))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> -    (inputs
> +    (propagated-inputs
>       `(("libdvdcss" ,libdvdcss)))
>      (description
>       "Libdvdread provides a simple foundation for reading DVD video
>
> ... because dvdread.pc Requires.private libdvdcss.
>
> Not sure what's up with meson's unhelpful error message...

I can confirm that this fixes the build of gnome-disk-utility.

Should we fix dvdread.pc, or propagate it with libdvdread?

Kind regards,
Roel Janssen

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Danny Milosavljevic]

Hi Roel,

On Thu, 04 Jan 2018 14:59:53 +0100
Roel Janssen <roel@gnu.org> wrote:

> I can confirm that this fixes the build of gnome-disk-utility.
> 
> Should we fix dvdread.pc, or propagate it with libdvdread?

I think we should propagate.  If libdvdread is requiring libdvdcss (whether private or not) then libdvdcss ['s pc file] should be there when libdvdread is used...

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Roel Janssen]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]


Danny Milosavljevic writes:

> Hi Roel,
>
> On Thu, 04 Jan 2018 14:59:53 +0100
> Roel Janssen <roel@gnu.org> wrote:
>
>> I can confirm that this fixes the build of gnome-disk-utility.
>> 
>> Should we fix dvdread.pc, or propagate it with libdvdread?
>
> I think we should propagate.  If libdvdread is requiring libdvdcss (whether private or not) then libdvdcss ['s pc file] should be there when libdvdread is used...

In that case, may I apply the attached patch?

Thanks!

Kind regards,
Roel Janssen


[-- Attachment #2: 0001-gnu-vlc-Enable-libdvdread-and-libdvdcss-support.patch --]
[-- Type: text/x-patch, Size: 1347 bytes --]

From b7fa57648b5cd45a5ce4f234c99c42fad42366b4 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Thu, 4 Jan 2018 16:25:44 +0100
Subject: [PATCH] gnu: vlc: Enable libdvdread and libdvdcss support.

* gnu/packages/video.scm (libdvdread): Compile with libdvdcss support;
  (vlc): Add libdvdread as input.
---
 gnu/packages/video.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 2d638abfe..77a82bb9d 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2017 Gregor Giesen <giesen@zaehlwerk.net>
 ;;; Copyright © 2017 Rutger Helling <rhelling@mykolab.com>
+;;; Copyright © 2018 Roel Janssen <roel@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1357,6 +1358,12 @@ players, like VLC or MPlayer.")
                (base32
                 "0ayqiq0psq18rcp6f5pz82sxsq66v0kwv0y55dbrcg68plnxy71j"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--with-libdvdcss=yes")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (propagated-inputs
+     `(("libdvdcss" ,libdvdcss)))
     (home-page "http://dvdnav.mplayerhq.hu/")
     (synopsis "Library for reading video DVDs")
     (description
-- 
2.15.1

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Mark H Weaver]

Roel Janssen <roel@gnu.org> writes:

> Danny Milosavljevic writes:
>
>> Hi Roel,
>>
>> On Thu, 04 Jan 2018 14:59:53 +0100
>> Roel Janssen <roel@gnu.org> wrote:
>>
>>> I can confirm that this fixes the build of gnome-disk-utility.
>>> 
>>> Should we fix dvdread.pc, or propagate it with libdvdread?
>>
>> I think we should propagate.  If libdvdread is requiring libdvdcss
>> (whether private or not) then libdvdcss ['s pc file] should be there
>> when libdvdread is used...
>
> In that case, may I apply the attached patch?

Looks good to me.  Thanks to you both for working on it!

     Mark

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Danny Milosavljevic]

LGTM!

Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support.

[Roel Janssen]

Mark H Weaver writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Danny Milosavljevic writes:
>>
>>> Hi Roel,
>>>
>>> On Thu, 04 Jan 2018 14:59:53 +0100
>>> Roel Janssen <roel@gnu.org> wrote:
>>>
>>>> I can confirm that this fixes the build of gnome-disk-utility.
>>>> 
>>>> Should we fix dvdread.pc, or propagate it with libdvdread?
>>>
>>> I think we should propagate.  If libdvdread is requiring libdvdcss
>>> (whether private or not) then libdvdcss ['s pc file] should be there
>>> when libdvdread is used...
>>
>> In that case, may I apply the attached patch?
>
> Looks good to me.  Thanks to you both for working on it!
>
>      Mark

Thanks both for reporting and fixing the problem.
I pushed the new path in e21f34735.

Kind regards,
Roel Janssen