unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/01: gnu: gpm: Fix build.
       [not found] ` <20170904193628.A7C1220950@vcs0.savannah.gnu.org>
@ 2017-09-04 20:29   ` Mark H Weaver
  2017-09-05  8:28     ` Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Mark H Weaver @ 2017-09-04 20:29 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: guix-devel

efraim@flashner.co.il (Efraim Flashner) writes:

> efraim pushed a commit to branch master
> in repository guix.
>
> commit 77bb6c227b441277e48d6e2071cca3b801f53374
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Mon Sep 4 22:35:25 2017 +0300
>
>     gnu: gpm: Fix build.
>     
>     * gnu/packages/linux.scm (gpm)[arguments]: Patch autogen.sh shebang
>     during the 'boottstrap phase.
> ---
>  gnu/packages/linux.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 3975c94..245b36f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -3126,6 +3126,8 @@ write access to exFAT devices.")
>                      (lambda _
>                        ;; The tarball was not generated with 'make dist' so we
>                        ;; need to bootstrap things ourselves.
> +                      (substitute* "autogen.sh"
> +                        (("/bin/sh") (which "sh")))
>                        (and (zero? (system* "./autogen.sh"))

Another way to fix this kind of problem, and IMO the preferable way, is
to change

  (system* "./autogen.sh")

to

  (system* "sh" "autogen.sh")

       Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 01/01: gnu: gpm: Fix build.
  2017-09-04 20:29   ` 01/01: gnu: gpm: Fix build Mark H Weaver
@ 2017-09-05  8:28     ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2017-09-05  8:28 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Mon, Sep 04, 2017 at 04:29:19PM -0400, Mark H Weaver wrote:
> efraim@flashner.co.il (Efraim Flashner) writes:
> 
> > efraim pushed a commit to branch master
> > in repository guix.
> >
> > commit 77bb6c227b441277e48d6e2071cca3b801f53374
> > Author: Efraim Flashner <efraim@flashner.co.il>
> > Date:   Mon Sep 4 22:35:25 2017 +0300
> >
> >     gnu: gpm: Fix build.
> >     
> >     * gnu/packages/linux.scm (gpm)[arguments]: Patch autogen.sh shebang
> >     during the 'boottstrap phase.
> > ---
> >  gnu/packages/linux.scm | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> > index 3975c94..245b36f 100644
> > --- a/gnu/packages/linux.scm
> > +++ b/gnu/packages/linux.scm
> > @@ -3126,6 +3126,8 @@ write access to exFAT devices.")
> >                      (lambda _
> >                        ;; The tarball was not generated with 'make dist' so we
> >                        ;; need to bootstrap things ourselves.
> > +                      (substitute* "autogen.sh"
> > +                        (("/bin/sh") (which "sh")))
> >                        (and (zero? (system* "./autogen.sh"))
> 
> Another way to fix this kind of problem, and IMO the preferable way, is
> to change
> 
>   (system* "./autogen.sh")
> 
> to
> 
>   (system* "sh" "autogen.sh")
> 
>        Mark

That's what we had for weechat, and it wasn't enough

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-05  8:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20170904193627.26984.31087@vcs0.savannah.gnu.org>
     [not found] ` <20170904193628.A7C1220950@vcs0.savannah.gnu.org>
2017-09-04 20:29   ` 01/01: gnu: gpm: Fix build Mark H Weaver
2017-09-05  8:28     ` Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).