* [PATCH] service: Fix arguments passing in the 'restart' action.
@ 2017-07-08 10:00 宋文武
2017-07-08 11:46 ` Danny Milosavljevic
2017-07-10 15:17 ` Ludovic Courtès
0 siblings, 2 replies; 3+ messages in thread
From: 宋文武 @ 2017-07-08 10:00 UTC (permalink / raw)
To: guix-devel
* modules/shepherd/service.scm (action): Use 'apply' to invoke the 'start'
procedure in the 'restart' action.
---
modules/shepherd/service.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
index 26f29aa..72fbc3d 100644
--- a/modules/shepherd/service.scm
+++ b/modules/shepherd/service.scm
@@ -398,7 +398,7 @@ wire."
(if running
(stop obj)
(local-output "~a was not running." (canonical-name obj)))
- (start obj args)))
+ (apply start obj args)))
((status)
;; Return the service itself. It is automatically converted to an sexp
;; via 'result->sexp' and sent to the client.
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] service: Fix arguments passing in the 'restart' action.
2017-07-08 10:00 [PATCH] service: Fix arguments passing in the 'restart' action 宋文武
@ 2017-07-08 11:46 ` Danny Milosavljevic
2017-07-10 15:17 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Danny Milosavljevic @ 2017-07-08 11:46 UTC (permalink / raw)
To: 宋文武; +Cc: guix-devel
On Sat, 8 Jul 2017 18:00:34 +0800
宋文武 <iyzsong@member.fsf.org> wrote:
> - (start obj args)))
> + (apply start obj args)))
LGTM!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] service: Fix arguments passing in the 'restart' action.
2017-07-08 10:00 [PATCH] service: Fix arguments passing in the 'restart' action 宋文武
2017-07-08 11:46 ` Danny Milosavljevic
@ 2017-07-10 15:17 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2017-07-10 15:17 UTC (permalink / raw)
To: 宋文武; +Cc: guix-devel
Hello,
宋文武 <iyzsong@member.fsf.org> skribis:
> * modules/shepherd/service.scm (action): Use 'apply' to invoke the 'start'
> procedure in the 'restart' action.
> ---
> modules/shepherd/service.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
> index 26f29aa..72fbc3d 100644
> --- a/modules/shepherd/service.scm
> +++ b/modules/shepherd/service.scm
> @@ -398,7 +398,7 @@ wire."
> (if running
> (stop obj)
> (local-output "~a was not running." (canonical-name obj)))
> - (start obj args)))
> + (apply start obj args)))
Good catch! Applied, thanks.
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-10 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-08 10:00 [PATCH] service: Fix arguments passing in the 'restart' action 宋文武
2017-07-08 11:46 ` Danny Milosavljevic
2017-07-10 15:17 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).