unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: gnu: Add syncthing.
Date: Tue, 24 Jan 2017 23:53:00 -0500	[thread overview]
Message-ID: <20170125045300.GA13222@jasmine> (raw)
In-Reply-To: <ff8c9e760586d63f67f33cbcf1c23ccc@mykolab.ch>

On Fri, Dec 16, 2016 at 01:48:57PM +0100, Petter wrote:
> On 2016-12-16 02:52, Leo Famulari wrote:
> > On Thu, Dec 15, 2016 at 10:06:59PM +0100, Petter wrote:
> > > +    (arguments
> > > +     `(#:import-path "github.com/syncthing/syncthing"
> > 
> > What do you think about having the go-build-system try to automatically
> > generate the import-path based on the source URL, with the option for
> > the packager to set it manually, as shown here?
> > 
> > For many of the packages in this patch (which will eventually be split
> > into one package per patch ;) ), that auto-generated import-path
> > could be correct.
> > 
> > I think that an (arguments) field indicates that the package's build
> > scripts have deviated from the standard. If a Guix build system requires
> > all of its packages to do something in (arguments), the build system
> > should be extended :)
> 
> This is my goal, and I tried to accomplish this initially, because as
> you can see for git checkouts most of the time import-path is url
> minus scheme://. But I was unable to retrieve the url in the build
> phases. So I did it like this instead, to get something that worked;
> also something like #:import-path is required where import-path can't
> be derived from the url.
> 
> I would need concrete help with this, that is getting the url and
> perhaps what (method) was used.

Does anyone have any advice here?

The issue is that the Go build tools typically want the source code to
be unpacked in a directory structure based on the URL of the Git repo.
We can set it "by hand" in the package definition, which is what the
current go-build-system patches do, but it would be great to have a
default that worked most of the time.

  parent reply	other threads:[~2017-01-25  4:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 21:06 gnu: Add syncthing Petter
2016-12-16  1:52 ` Leo Famulari
2016-12-16 12:48   ` Petter
2016-12-17  0:24     ` Leo Famulari
2017-01-25  4:53     ` Leo Famulari [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-12-11  0:38 Petter
2016-12-11 11:25 ` Hartmut Goebel
2016-12-11 11:35   ` Hartmut Goebel
2016-12-11 19:09   ` Leo Famulari
2016-12-11 22:21     ` ng0
2016-12-13  6:58       ` Chris Marusich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125045300.GA13222@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=petter@mykolab.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).