From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: gnu: Add syncthing. Date: Tue, 24 Jan 2017 23:53:00 -0500 Message-ID: <20170125045300.GA13222@jasmine> References: <2d54ddb40494e3c6229e2a464ffe02c3@mykolab.ch> <20161216015222.GA23115@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWFa0-0005bP-3q for guix-devel@gnu.org; Tue, 24 Jan 2017 23:53:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWFZw-0007C4-4J for guix-devel@gnu.org; Tue, 24 Jan 2017 23:53:08 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39939) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWFZv-0007BG-TY for guix-devel@gnu.org; Tue, 24 Jan 2017 23:53:04 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org On Fri, Dec 16, 2016 at 01:48:57PM +0100, Petter wrote: > On 2016-12-16 02:52, Leo Famulari wrote: > > On Thu, Dec 15, 2016 at 10:06:59PM +0100, Petter wrote: > > > + (arguments > > > + `(#:import-path "github.com/syncthing/syncthing" > > > > What do you think about having the go-build-system try to automatically > > generate the import-path based on the source URL, with the option for > > the packager to set it manually, as shown here? > > > > For many of the packages in this patch (which will eventually be split > > into one package per patch ;) ), that auto-generated import-path > > could be correct. > > > > I think that an (arguments) field indicates that the package's build > > scripts have deviated from the standard. If a Guix build system requires > > all of its packages to do something in (arguments), the build system > > should be extended :) > > This is my goal, and I tried to accomplish this initially, because as > you can see for git checkouts most of the time import-path is url > minus scheme://. But I was unable to retrieve the url in the build > phases. So I did it like this instead, to get something that worked; > also something like #:import-path is required where import-path can't > be derived from the url. > > I would need concrete help with this, that is getting the url and > perhaps what (method) was used. Does anyone have any advice here? The issue is that the Go build tools typically want the source code to be unpacked in a directory structure based on the URL of the Git repo. We can set it "by hand" in the package definition, which is what the current go-build-system patches do, but it would be great to have a default that worked most of the time.