From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog.
Date: Tue, 17 Jan 2017 15:53:57 -0500 [thread overview]
Message-ID: <20170117205357.GB17056@jasmine> (raw)
In-Reply-To: <20170116152125.0f011148@scratchpost.org>
On Mon, Jan 16, 2017 at 03:21:29PM +0100, Danny Milosavljevic wrote:
> Hi,
>
> > I should have probably added a different phase for the
> > "icebox/icebox_vlog.py" substitution, to make clear it's the only path
> > which is a run-time reference. The installed icebox_vlog, can't find the
> > chipdb.txt file, if we don't make the substitution.
>
> Yeah, I think how you did it now is best.
>
> LGTM!
>
> I've built it and it works.
>
> I'll leave some time for others to comment. Afterwards, I'll commit it
> to master (since it'll cause rebuild of one icestorm-dependent
> package).
LGTM! Thanks Theodoros and Danny!
next prev parent reply other threads:[~2017-01-17 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 18:56 [PATCH 0/1] gnu: icestorm: Replace reference in icebox_vlog Theodoros Foradis
2017-01-14 18:56 ` [PATCH 1/1] " Theodoros Foradis
2017-01-14 19:25 ` Danny Milosavljevic
2017-01-16 10:11 ` Theodoros Foradis
2017-01-16 14:21 ` Danny Milosavljevic
2017-01-17 20:53 ` Leo Famulari [this message]
2017-03-10 19:22 ` Theodoros Foradis
2017-03-10 21:13 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117205357.GB17056@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).