From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog.
Date: Tue, 17 Jan 2017 15:53:57 -0500
Message-ID: <20170117205357.GB17056@jasmine>
References: <20170114185652.29952-1-theodoros.for@openmailbox.org>
	<20170114185652.29952-2-theodoros.for@openmailbox.org>
	<20170114202524.0f056d54@scratchpost.org>
	<87tw8zs49o.fsf@openmailbox.org>
	<20170116152125.0f011148@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cTalX-00083V-8Q
	for guix-devel@gnu.org; Tue, 17 Jan 2017 15:54:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cTalU-000522-1O
	for guix-devel@gnu.org; Tue, 17 Jan 2017 15:54:03 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43888)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cTalT-00051f-Nx
	for guix-devel@gnu.org; Tue, 17 Jan 2017 15:53:59 -0500
Content-Disposition: inline
In-Reply-To: <20170116152125.0f011148@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Guix-devel <guix-devel@gnu.org>

On Mon, Jan 16, 2017 at 03:21:29PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> > I should have probably added a different phase for the
> > "icebox/icebox_vlog.py" substitution, to make clear it's the only path
> > which is a run-time reference. The installed icebox_vlog, can't find the
> > chipdb.txt file, if we don't make the substitution.
> 
> Yeah, I think how you did it now is best.
> 
> LGTM!
> 
> I've built it and it works.
> 
> I'll leave some time for others to comment. Afterwards, I'll commit it
> to master (since it'll cause rebuild of one icestorm-dependent
> package).

LGTM! Thanks Theodoros and Danny!