From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: add proj4.
Date: Mon, 16 Jan 2017 00:21:28 +0100 [thread overview]
Message-ID: <20170116002121.1aec454e@scratchpost.org> (raw)
In-Reply-To: <20170115232402.17585716@alma-ubu>
Hi,
> * gnu/packages/geo.scm:139:13: proj4-4.9.3: invalid license field
>
> But the documentation explicitly speaks about list values. What's wrong?
You quoted the list. That means that all the symbols in it stay symbols and are not resolved. Instead of substituting the actual license license:asl2.0, it will literally put 'license:asl2.0 into the list.
I'd just use something like (list license:a license:b) .
It would also be possible to use quasiquote but I'd not do that in this case. It's too obtuse. `(,license:a ,license:b)
> * /home/bjoern/guix/gnu/packages/geo.scm:100:2: proj4-4.9.3: line 125 is way too long (102 characters)
It's an URL in a comment - I'd be fine with it as-is and I wouldn't break it anywhere.
> About the package name: The official name is "proj.4", so I left it as that.
Seems reasonable.
> As variable name, I chose "proj4". Is that correct?
Why not use the variable name "proj.4" too then? *scratches head*
next prev parent reply other threads:[~2017-01-15 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 22:21 [PATCH] gnu: add proj4 Björn Höfling
2017-01-15 22:24 ` Björn Höfling
2017-01-15 23:21 ` Danny Milosavljevic [this message]
2017-01-16 20:05 ` Björn Höfling
2017-01-16 22:46 ` Leo Famulari
2017-01-17 13:42 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116002121.1aec454e@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).