From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH] gnu: add proj4. Date: Mon, 16 Jan 2017 00:21:28 +0100 Message-ID: <20170116002121.1aec454e@scratchpost.org> References: <20170115232147.2ee240cc@alma-ubu> <20170115232402.17585716@alma-ubu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSu7I-0000Gs-Ti for guix-devel@gnu.org; Sun, 15 Jan 2017 18:21:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSu7E-0004ZX-1q for guix-devel@gnu.org; Sun, 15 Jan 2017 18:21:40 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:34253) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cSu7D-0004ZM-RR for guix-devel@gnu.org; Sun, 15 Jan 2017 18:21:35 -0500 In-Reply-To: <20170115232402.17585716@alma-ubu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?ISO-8859-1?Q?Bj=F6rn_H=F6fling?= Cc: guix-devel@gnu.org Hi, > * gnu/packages/geo.scm:139:13: proj4-4.9.3: invalid license field > > But the documentation explicitly speaks about list values. What's wrong? You quoted the list. That means that all the symbols in it stay symbols and are not resolved. Instead of substituting the actual license license:asl2.0, it will literally put 'license:asl2.0 into the list. I'd just use something like (list license:a license:b) . It would also be possible to use quasiquote but I'd not do that in this case. It's too obtuse. `(,license:a ,license:b) > * /home/bjoern/guix/gnu/packages/geo.scm:100:2: proj4-4.9.3: line 125 is way too long (102 characters) It's an URL in a comment - I'd be fine with it as-is and I wouldn't break it anywhere. > About the package name: The official name is "proj.4", so I left it as that. Seems reasonable. > As variable name, I chose "proj4". Is that correct? Why not use the variable name "proj.4" too then? *scratches head*