unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Enable polkit for connman
@ 2017-01-01 17:30 Mathieu OTHACEHE
  2017-01-02 21:56 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Mathieu OTHACEHE @ 2017-01-01 17:30 UTC (permalink / raw)
  To: guix-devel

Connman was compiled without polkit support due to this error message during
configure phase :

pkg-config cannot find polkit.pc

It is a meaningless error produced by the following lines in
connman/configure.ac :

	POLKIT_DATADIR="`$PKG_CONFIG --variable=actiondir polkit`"
	POLKIT_DATADIR=""
	if (test -z "${POLKIT_DATADIR}"); then
		POLKIT_DATADIR="${datadir}/polkit-1/actions"
	fi

When compiled with --enable-polkit, everything seems to work fine and connman
can be used from an unprivileged account.
---
 gnu/packages/connman.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/connman.scm b/gnu/packages/connman.scm
index 6b061db58..ff6e71571 100644
--- a/gnu/packages/connman.scm
+++ b/gnu/packages/connman.scm
@@ -28,6 +28,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages polkit)
   #:use-module (gnu packages python)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages samba)
@@ -50,7 +51,7 @@
     (arguments
      `(#:configure-flags
        (list "--enable-nmcompat"
-             ;; "--enable-polkit"
+             "--enable-polkit"
              "--enable-openconnect"
              "--enable-openvpn"
              "--enable-vpnc"
@@ -71,7 +72,7 @@
        ("glib" ,glib)
        ("gnutls" ,gnutls)
        ("iptables" ,iptables)
-       ;; ("polkit" ,polkit) ; pkg-config cannot find polkit.pc
+       ("polkit" ,polkit)
        ("readline" ,readline)
        ;; These inputs are needed for connman to include the interface to
        ;; these technologies so IF they are installed they can be used.
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu: Enable polkit for connman
  2017-01-01 17:30 [PATCH] gnu: Enable polkit for connman Mathieu OTHACEHE
@ 2017-01-02 21:56 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2017-01-02 21:56 UTC (permalink / raw)
  To: Mathieu OTHACEHE; +Cc: guix-devel

Hi!

Mathieu OTHACEHE <m.othacehe@gmail.com> skribis:

> Connman was compiled without polkit support due to this error message during
> configure phase :
>
> pkg-config cannot find polkit.pc
>
> It is a meaningless error produced by the following lines in
> connman/configure.ac :
>
> 	POLKIT_DATADIR="`$PKG_CONFIG --variable=actiondir polkit`"
> 	POLKIT_DATADIR=""
> 	if (test -z "${POLKIT_DATADIR}"); then
> 		POLKIT_DATADIR="${datadir}/polkit-1/actions"
> 	fi
>
> When compiled with --enable-polkit, everything seems to work fine and connman
> can be used from an unprivileged account.

Nice!  Pushed with a ChangeLog-style commit log as
125e3cdeceb11a4b066209341f9fb7e052dd3695.

Thank you, and welcome!  :-)

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-02 21:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-01 17:30 [PATCH] gnu: Enable polkit for connman Mathieu OTHACEHE
2017-01-02 21:56 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).