hplip: Add qt5 gui.

hplip: Add qt5 gui.

[ng0]

We need to explicitly tell the configure to disable qt3 and qt4 to make it accept qt5 which is annoying.
Tested was just running hp-setup, worked for me.

[PATCH] gnu: hplip: Add qt5 gui.

[ng0]

* gnu/packages/cups.scm (hplip): Add gui.
[arguments](configure-flags): Add "--enable-gui-build", "--disable-qt3",
"--disable-qt4", "--enable-qt5", "--enable-dbus-build".
[inputs]: Add python-pyqt, python-pygobject and python-sip.
---
 gnu/packages/cups.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
index baa77f7aa..7069d6b66 100644
--- a/gnu/packages/cups.scm
+++ b/gnu/packages/cups.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015, 2016 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym@scratchpost.org>
+;;; Copyright © 2016 ng0 <ng0@libertad.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -38,7 +39,8 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages tls))
+  #:use-module (gnu packages tls)
+  #:use-module (gnu packages qt))
 
 ;; Delay to avoid module circularity problems.
 (define ghostscript/cups
@@ -346,6 +348,11 @@ device-specific programs to convert and print many types of files.")
          "--enable-new-hpcups"
          "--enable-cups_ppd_install"
          "--enable-cups_drv_install"
+         "--enable-gui-build"
+         "--disable-qt3"
+         "--disable-qt4"
+         "--enable-qt5"
+         "--enable-dbus-build"
          ;; TODO add foomatic drv install eventually.
          ;; TODO --enable-policykit eventually.
          ,(string-append "--with-cupsfilterdir="
@@ -420,6 +427,9 @@ device-specific programs to convert and print many types of files.")
               ("dbus" ,dbus)
               ("python-wrapper" ,python-wrapper)
               ("python" ,python)
+              ("python-pyqt" ,python-pyqt)
+              ("python-pygobject" ,python-pygobject)
+              ("python-sip" ,python-sip)
               ;; TODO: Make hp-setup find python-dbus.
               ("python-dbus" ,python-dbus)))
     (native-inputs `(("pkg-config" ,pkg-config)))))
-- 
2.11.0

Re: [PATCH] gnu: hplip: Add qt5 gui.

[Danny Milosavljevic]

Hi,

> +         "--enable-dbus-build"
>                ;; TODO: Make hp-setup find python-dbus.

Does that mean that dbus now works in hp-setup?

Re: [PATCH] gnu: hplip: Add qt5 gui.

[ng0]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
>> +         "--enable-dbus-build"
>>                ;; TODO: Make hp-setup find python-dbus.
>
> Does that mean that dbus now works in hp-setup?
>

I don't know. Before and afterwards I ran into the problem where
no user (in groups lp and lpadmin, even root) is authenticated
enough to finally add the printer (hp-setup -i -a -g).
I guess this is the source of this problem...?

I'm still looking into some problems with the gui, possibly
caused by some Guix specifics. The gui works in general, but what
doesn't work is adding your own ppd (you can select it in the
file-browser but it never gets displayed, therefore you can not
proceed beyond the first page), so I really assume this is dbus
or some other problem too. Nothing new, but the gui functionality
is expected by (some) users.
-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

Re: hplip: Add qt5 gui.

[ng0]

ng0 <ng0@libertad.pw> writes:

> We need to explicitly tell the configure to disable qt3 and qt4 to make it accept qt5 which is annoying.
> Tested was just running hp-setup, worked for me.

I just fixed the policykit issue (in theory, no more errors in
the build), so I change this patch a bit and send in both patches
in series.

-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

hplip: Add qt5 gui, try to fix policykit support

[ng0]

[PATCH 1/2] gnu: hplip: Add qt5 gui.

Same as before, removed the --enable-dbus and ...

[PATCH 2/2] gnu: hplip: Add policykit support.

... moved it here, with the additional policykit stuff.
I really have no idea how hplip is supposed to be used in Guix after reading the note about the base service. So we are not supposed to run and install it as users in profiles? Will it be in the cups service where I would have no idea how to add it in there?
I have cups running but my printer absolutely requires hplip.

[PATCH 1/2] gnu: hplip: Add qt5 gui.

[ng0]

* gnu/packages/cups.scm (hplip): Add gui.
[arguments](configure-flags): Add "--enable-gui-build", "--disable-qt4",
"--enable-qt5".
[inputs]: Add python-pyqt, python-pygobject and python-sip.
---
 gnu/packages/cups.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
index baa77f7aa..d264d6b12 100644
--- a/gnu/packages/cups.scm
+++ b/gnu/packages/cups.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015, 2016 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym@scratchpost.org>
+;;; Copyright © 2016 ng0 <ng0@libertad.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -38,7 +39,8 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages tls))
+  #:use-module (gnu packages tls)
+  #:use-module (gnu packages qt))
 
 ;; Delay to avoid module circularity problems.
 (define ghostscript/cups
@@ -346,6 +348,9 @@ device-specific programs to convert and print many types of files.")
          "--enable-new-hpcups"
          "--enable-cups_ppd_install"
          "--enable-cups_drv_install"
+         "--enable-gui-build"
+         "--disable-qt4"
+         "--enable-qt5"
          ;; TODO add foomatic drv install eventually.
          ;; TODO --enable-policykit eventually.
          ,(string-append "--with-cupsfilterdir="
@@ -420,6 +425,9 @@ device-specific programs to convert and print many types of files.")
               ("dbus" ,dbus)
               ("python-wrapper" ,python-wrapper)
               ("python" ,python)
+              ("python-pyqt" ,python-pyqt)
+              ("python-pygobject" ,python-pygobject)
+              ("python-sip" ,python-sip)
               ;; TODO: Make hp-setup find python-dbus.
               ("python-dbus" ,python-dbus)))
     (native-inputs `(("pkg-config" ,pkg-config)))))
-- 
2.11.0

[PATCH 2/2] gnu: hplip: Add policykit support.

[ng0]

* gnu/packages/cups.scm (hplip): Add policykit support.
[arguments](configure-flags): Add "--enable-dbus-build", "--enable-policykit".
[arguments](make-flags): Add "policykit_dbus_etcdir", "policykit_dir",
"policykit_dbus_sharedir".
(inputs): Add "polkit".
---
 gnu/packages/cups.scm | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm
index d264d6b12..ae975504b 100644
--- a/gnu/packages/cups.scm
+++ b/gnu/packages/cups.scm
@@ -40,6 +40,7 @@
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages polkit)
   #:use-module (gnu packages qt))
 
 ;; Delay to avoid module circularity problems.
@@ -351,8 +352,9 @@ device-specific programs to convert and print many types of files.")
          "--enable-gui-build"
          "--disable-qt4"
          "--enable-qt5"
+         "--enable-dbus-build"
+         "--enable-policykit"
          ;; TODO add foomatic drv install eventually.
-         ;; TODO --enable-policykit eventually.
          ,(string-append "--with-cupsfilterdir="
                          (assoc-ref %outputs "out") "/lib/cups/filter")
          ,(string-append "--with-cupsbackenddir="
@@ -362,6 +364,19 @@ device-specific programs to convert and print many types of files.")
          ,(string-append "--with-systraydir="
                          (assoc-ref %outputs "out") "/etc/xdg"))
 
+       #:make-flags
+       ;; Already set in 'fix-hard-coded-file-names phase:
+       ;; "rulesdir" and "halpredir".
+       `(,(string-append "policykit_dbus_etcdir="
+                         (assoc-ref %outputs "out")
+                         "/etc/dbus-1/system.d")
+         ,(string-append "policykit_dir="
+                         (assoc-ref %outputs "out")
+                         "/share/polkit-1/actions")
+         ,(string-append "policykit_dbus_sharedir="
+                         (assoc-ref %outputs "out")
+                         "/share/dbus-1/system-services"))
+
        #:imported-modules ((guix build python-build-system)
                            ,@%gnu-build-system-modules)
        #:modules ((guix build gnu-build-system)
@@ -429,5 +444,6 @@ device-specific programs to convert and print many types of files.")
               ("python-pygobject" ,python-pygobject)
               ("python-sip" ,python-sip)
               ;; TODO: Make hp-setup find python-dbus.
-              ("python-dbus" ,python-dbus)))
+              ("python-dbus" ,python-dbus)
+              ("polkit" ,polkit)))
     (native-inputs `(("pkg-config" ,pkg-config)))))
-- 
2.11.0

Re: [PATCH 1/2] gnu: hplip: Add qt5 gui.

[Ludovic Courtès]

Hi!

ng0 <ng0@libertad.pw> skribis:

> * gnu/packages/cups.scm (hplip): Add gui.
> [arguments](configure-flags): Add "--enable-gui-build", "--disable-qt4",
> "--enable-qt5".
> [inputs]: Add python-pyqt, python-pygobject and python-sip.

Seems like this would multiply the closure of ‘sane-backends’ by 5:

--8<---------------cut here---------------start------------->8---
$ guix size sane-backends|tail -1
total: 294.1 MiB
$ guix size sane-backends qt@5|tail -1
total: 1486.9 MiB
--8<---------------cut here---------------end--------------->8---

Could you try moving the GUI to a separate output or to a separate
package?

Thanks,
Ludo’.

Re: hplip: Add qt5 gui, try to fix policykit support

[Andy Patterson]

Hey ng0,


On Thu, 29 Dec 2016 14:05:51 +0000
ng0 <ng0@libertad.pw> wrote:


> I really have no idea how hplip is supposed to be used in Guix after
> reading the note about the base service. So we are not supposed to
> run and install it as users in profiles? Will it be in the cups
> service where I would have no idea how to add it in there? 

I've been printing with an hp for a little while now, and in my system
configuration I have this:

(service cups-service-type
         (cups-configuration
          (web-interface? #t)
          (extensions
           (list cups-filters hplip))))

Maybe you've already done that, but I'm just guessing based on what you
wrote.

I've found that with that configuration, all of hplip's ppd files show
up when adding the printer via the web interface (which is how I added
my printer). hp-setup also seems to work ok, and will auto-detect your
ppd file, but can't print out the test page.

Anyway, I hope that helps.

--
Andy

Re: hplip: Add qt5 gui, try to fix policykit support

[ng0]

Andy Patterson <ajpatter@uwaterloo.ca> writes:

> Hey ng0,
>
>
> On Thu, 29 Dec 2016 14:05:51 +0000
> ng0 <ng0@libertad.pw> wrote:
>
>
>> I really have no idea how hplip is supposed to be used in Guix after
>> reading the note about the base service. So we are not supposed to
>> run and install it as users in profiles? Will it be in the cups
>> service where I would have no idea how to add it in there? 
>
> I've been printing with an hp for a little while now, and in my system
> configuration I have this:
>
> (service cups-service-type
>          (cups-configuration
>           (web-interface? #t)
>           (extensions
>            (list cups-filters hplip))))
>
> Maybe you've already done that, but I'm just guessing based on what you
> wrote.
>
> I've found that with that configuration, all of hplip's ppd files show
> up when adding the printer via the web interface (which is how I added
> my printer). hp-setup also seems to work ok, and will auto-detect your
> ppd file, but can't print out the test page.
>
> Anyway, I hope that helps.
>
> --
> Andy
>

Hm! Okay, I will try this as soon as I can.
I've been a bit slow with splitting out the qt5 gui, but I will
update the patch soon.

Thanks!
-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

CUPS and HP printers

[Ludovic Courtès]

Hi Andy,

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> On Thu, 29 Dec 2016 14:05:51 +0000
> ng0 <ng0@libertad.pw> wrote:
>
>
>> I really have no idea how hplip is supposed to be used in Guix after
>> reading the note about the base service. So we are not supposed to
>> run and install it as users in profiles? Will it be in the cups
>> service where I would have no idea how to add it in there? 
>
> I've been printing with an hp for a little while now, and in my system
> configuration I have this:
>
> (service cups-service-type
>          (cups-configuration
>           (web-interface? #t)
>           (extensions
>            (list cups-filters hplip))))

Interesting.  Maybe we should document it somewhere or simply provide
this example in the manual, because it’s not necessarily obvious.

WDYT?

Ludo’.

Re: CUPS and HP printers

[ng0]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Andy,
>
> Andy Patterson <ajpatter@uwaterloo.ca> skribis:
>
>> On Thu, 29 Dec 2016 14:05:51 +0000
>> ng0 <ng0@libertad.pw> wrote:
>>
>>
>>> I really have no idea how hplip is supposed to be used in Guix after
>>> reading the note about the base service. So we are not supposed to
>>> run and install it as users in profiles? Will it be in the cups
>>> service where I would have no idea how to add it in there? 
>>
>> I've been printing with an hp for a little while now, and in my system
>> configuration I have this:
>>
>> (service cups-service-type
>>          (cups-configuration
>>           (web-interface? #t)
>>           (extensions
>>            (list cups-filters hplip))))
>
> Interesting.  Maybe we should document it somewhere or simply provide
> this example in the manual, because it’s not necessarily obvious.
>
> WDYT?
>
> Ludo’.
>

Ha! I just printed using GuixSD :)
The way Andy described worked. We should really add this to the
documentation.

Related to this thread, I see if I can apply the suggested
changes this week.

Thank you very much Andy :)
-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: CUPS and HP printers

[Ludovic Courtès]

ng0 <contact.ng0@cryptolab.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Andy,
>>
>> Andy Patterson <ajpatter@uwaterloo.ca> skribis:
>>
>>> On Thu, 29 Dec 2016 14:05:51 +0000
>>> ng0 <ng0@libertad.pw> wrote:
>>>
>>>
>>>> I really have no idea how hplip is supposed to be used in Guix after
>>>> reading the note about the base service. So we are not supposed to
>>>> run and install it as users in profiles? Will it be in the cups
>>>> service where I would have no idea how to add it in there? 
>>>
>>> I've been printing with an hp for a little while now, and in my system
>>> configuration I have this:
>>>
>>> (service cups-service-type
>>>          (cups-configuration
>>>           (web-interface? #t)
>>>           (extensions
>>>            (list cups-filters hplip))))
>>
>> Interesting.  Maybe we should document it somewhere or simply provide
>> this example in the manual, because it’s not necessarily obvious.

Done!

Ludo’.