From: Danny Milosavljevic <dannym@scratchpost.org>
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: Fix load-extension path in packaging of guile-ncurses.
Date: Wed, 21 Dec 2016 09:36:56 +0100 [thread overview]
Message-ID: <20161221093656.400cd7cd@scratchpost.org> (raw)
In-Reply-To: <20161220110331.GA20543@jocasta.intra>
> Sure (I would like to see a convention where such explanations are
> put in the commit messaage, but I have previously been outvoted on
> that issue):
No, please don't put explanations into the commit message. But do put them into the source code as a comment.
I'm also working on other projects, some of which do what you propose. What I often end up having to do there is do git blame, then git log for each line, in order to find out why the source code does what it does. Let's not do that here. There's a perfectly good inline mechanism for it: Comments.
next prev parent reply other threads:[~2016-12-21 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 17:50 (unknown), John Darrington
2016-12-19 17:50 ` [PATCH] gnu: Fix load-extension path in packaging of guile-ncurses John Darrington
2016-12-19 21:17 ` Ludovic Courtès
2016-12-20 7:17 ` Mark H Weaver
2016-12-20 11:03 ` John Darrington
2016-12-20 14:16 ` John Darrington
2016-12-21 8:36 ` Danny Milosavljevic [this message]
2016-12-21 9:56 ` John Darrington
2016-12-22 5:56 ` Tobias Geerinckx-Rice
2016-12-22 8:20 ` John Darrington
2016-12-24 15:39 ` Mark H Weaver
2016-12-24 17:02 ` John Darrington
2017-01-16 0:11 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221093656.400cd7cd@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).