From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH] gnu: Fix load-extension path in packaging of guile-ncurses. Date: Wed, 21 Dec 2016 09:36:56 +0100 Message-ID: <20161221093656.400cd7cd@scratchpost.org> References: <1482169820-2043-1-git-send-email-jmd@gnu.org> <1482169820-2043-2-git-send-email-jmd@gnu.org> <87lgvb9ii1.fsf@netris.org> <20161220110331.GA20543@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJcOa-0004x6-L5 for guix-devel@gnu.org; Wed, 21 Dec 2016 03:37:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJcOX-000710-GR for guix-devel@gnu.org; Wed, 21 Dec 2016 03:37:08 -0500 In-Reply-To: <20161220110331.GA20543@jocasta.intra> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org, John Darrington > Sure (I would like to see a convention where such explanations are > put in the commit messaage, but I have previously been outvoted on > that issue): No, please don't put explanations into the commit message. But do put them into the source code as a comment. I'm also working on other projects, some of which do what you propose. What I often end up having to do there is do git blame, then git log for each line, in order to find out why the source code does what it does. Let's not do that here. There's a perfectly good inline mechanism for it: Comments.