From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Pytest update to 2.9.2
Date: Thu, 8 Dec 2016 19:28:30 -0500 [thread overview]
Message-ID: <20161209002830.GA3148@jasmine> (raw)
In-Reply-To: <584695D4.504@crazy-compilers.com>
On Tue, Dec 06, 2016 at 11:41:24AM +0100, Hartmut Goebel wrote:
> Am 05.12.2016 um 22:33 schrieb Leo Famulari:
> > + (substitute* "testing/test_argcomplete.py"
> > + (("def test_remove_dir_prefix" line)
> > + (string-append "@pytest.mark.skip"
> > + "(reason=\"Assumes that /usr exists.\")\n "
> > + line)))
>
> These trailing spaces in the replacement string are a bit irritating.
> Perhaps its better to search for "^\s+def …" and replace with "
> @pytest.skip…" (leading spaces here). I don't know.
>
> Otherwise LGTM.
Should we try this with your Sphinx update patches on a python-updates
branch? After staging is merged?
prev parent reply other threads:[~2016-12-09 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 21:33 Pytest update to 2.9.2 Leo Famulari
2016-12-06 10:41 ` Hartmut Goebel
2016-12-09 0:28 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209002830.GA3148@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).