From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Pytest update to 2.9.2 Date: Thu, 8 Dec 2016 19:28:30 -0500 Message-ID: <20161209002830.GA3148@jasmine> References: <20161205213343.GA20927@jasmine> <584695D4.504@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF93L-0000J6-TS for guix-devel@gnu.org; Thu, 08 Dec 2016 19:28:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF93I-0006Oa-PA for guix-devel@gnu.org; Thu, 08 Dec 2016 19:28:43 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42893) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cF93I-0006OM-Hy for guix-devel@gnu.org; Thu, 08 Dec 2016 19:28:40 -0500 Content-Disposition: inline In-Reply-To: <584695D4.504@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel On Tue, Dec 06, 2016 at 11:41:24AM +0100, Hartmut Goebel wrote: > Am 05.12.2016 um 22:33 schrieb Leo Famulari: > > + (substitute* "testing/test_argcomplete.py" > > + (("def test_remove_dir_prefix" line) > > + (string-append "@pytest.mark.skip" > > + "(reason=\"Assumes that /usr exists.\")\n " > > + line))) > > These trailing spaces in the replacement string are a bit irritating. > Perhaps its better to search for "^\s+def …" and replace with " > @pytest.skip…" (leading spaces here). I don't know. > > Otherwise LGTM. Should we try this with your Sphinx update patches on a python-updates branch? After staging is merged?