From: Eric Bavier <ericbavier@centurylink.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] import: cpan: Add CPAN updater.
Date: Wed, 7 Dec 2016 23:45:20 -0600 [thread overview]
Message-ID: <20161207234520.49e0410e@centurylink.net> (raw)
In-Reply-To: <87zik880j8.fsf@gnu.org>
On Wed, 07 Dec 2016 12:02:35 +0100
ludo@gnu.org (Ludovic Courtès) wrote:
> Eric Bavier <bavier@member.fsf.org> skribis:
>
> > * guix/import/cpan.scm (module->dist-name): Fetch the field of interest.
> > (cpan-fetch): Accept release name rather than module name.
> > (fix-source-url): Rename to ...
> > (cpan-source-url): ... this. Take metadata as parameter.
> > (cpan-module->sexp): Move local core-module? procedure to ...
> > (core-module?): ... here.
> > (package->upstream-name, cpan-version, cpan-package?, latest-release):
> > New procedures.
> > (%cpan-updater): New variable.
> > * guix/scripts/refresh.scm (%updaters): Add %cpan-updater.
>
> [...]
>
> > +(define core-module?
> > + (let ((perl-version (package-version perl))
> > + (rx (make-regexp
> > + (string-append "released with perl v?([0-9\\.]*)"
> > + "(.*and removed from v?([0-9\\.]*))?"))))
> > + (lambda (name)
>
> For clarity you could make this change (moving ‘core-module?’ to the top
> level) in a separate patch maybe.
Good idea.
> Otherwise that LGTM, though I haven’t actually tested it.
Great. For me it detects over 100 package upgrades :)
`~Eric
next prev parent reply other threads:[~2016-12-08 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 5:03 [PATCH 1/2] import: json: Silence json-fetch output Eric Bavier
2016-12-05 5:03 ` [PATCH 2/2] import: cpan: Add CPAN updater Eric Bavier
2016-12-07 11:02 ` Ludovic Courtès
2016-12-08 5:45 ` Eric Bavier [this message]
2016-12-07 10:59 ` [PATCH 1/2] import: json: Silence json-fetch output Ludovic Courtès
2016-12-08 5:57 ` Eric Bavier
2016-12-08 9:52 ` Ludovic Courtès
2016-12-14 15:16 ` David Craven
2016-12-15 17:37 ` Ludovic Courtès
2016-12-20 2:50 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207234520.49e0410e@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).