From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@centurylink.net>
Subject: Re: [PATCH 2/2] import: cpan: Add CPAN updater.
Date: Wed, 7 Dec 2016 23:45:20 -0600
Message-ID: <20161207234520.49e0410e@centurylink.net>
References: <20161205050317.13222-1-bavier@member.fsf.org>
	<20161205050317.13222-2-bavier@member.fsf.org>
	<87zik880j8.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@centurylink.net>) id 1cErWI-0006ST-Ma
	for guix-devel@gnu.org; Thu, 08 Dec 2016 00:45:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@centurylink.net>) id 1cErWF-0002ZB-WA
	for guix-devel@gnu.org; Thu, 08 Dec 2016 00:45:26 -0500
Received: from mail.centurylink.net ([205.219.233.9]:34418
	helo=smtp.centurylink.net)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ericbavier@centurylink.net>)
	id 1cErWF-0002Y5-QI
	for guix-devel@gnu.org; Thu, 08 Dec 2016 00:45:23 -0500
In-Reply-To: <87zik880j8.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Wed, 07 Dec 2016 12:02:35 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Eric Bavier <bavier@member.fsf.org> skribis:
>=20
> > * guix/import/cpan.scm (module->dist-name): Fetch the field of interest.
> > (cpan-fetch): Accept release name rather than module name.
> > (fix-source-url): Rename to ...
> > (cpan-source-url): ... this.  Take metadata as parameter.
> > (cpan-module->sexp): Move local core-module? procedure to ...
> > (core-module?): ... here.
> > (package->upstream-name, cpan-version, cpan-package?, latest-release):
> > New procedures.
> > (%cpan-updater): New variable.
> > * guix/scripts/refresh.scm (%updaters): Add %cpan-updater. =20
>=20
> [...]
>=20
> > +(define core-module?
> > +  (let ((perl-version (package-version perl))
> > +        (rx (make-regexp
> > +             (string-append "released with perl v?([0-9\\.]*)"
> > +                            "(.*and removed from v?([0-9\\.]*))?"))))
> > +    (lambda (name) =20
>=20
> For clarity you could make this change (moving =E2=80=98core-module?=E2=
=80=99 to the top
> level) in a separate patch maybe.

Good idea.

> Otherwise that LGTM, though I haven=E2=80=99t actually tested it.

Great.  For me it detects over 100 package upgrades :)

`~Eric