unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 1/2] gnu: python-pafy: Disable tests.
@ 2016-11-16 12:27 ng0
  2016-11-16 12:27 ` [PATCH 2/2] gnu: mps-youtube: " ng0
  2016-11-18 20:17 ` [PATCH 1/2] gnu: python-pafy: " Leo Famulari
  0 siblings, 2 replies; 4+ messages in thread
From: ng0 @ 2016-11-16 12:27 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/python.scm (python-pafy): Disable tests.
---
 gnu/packages/python.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 18e485a..7cf1e7c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1620,6 +1620,8 @@ standard library.")
         (base32
          "1ckvrypyvb7jbqlgwdz0y337ajagjv7dgxyns326nqwypn1wpq0i"))))
     (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ; Currently pafy can not find itself in the tests
     (propagated-inputs
      ;; Youtube-dl is a python package which is imported in the file
      ;; "backend_youtube_dl.py", therefore it needs to be propagated.
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] gnu: mps-youtube: Disable tests.
  2016-11-16 12:27 [PATCH 1/2] gnu: python-pafy: Disable tests ng0
@ 2016-11-16 12:27 ` ng0
  2016-11-18 20:17   ` Leo Famulari
  2016-11-18 20:17 ` [PATCH 1/2] gnu: python-pafy: " Leo Famulari
  1 sibling, 1 reply; 4+ messages in thread
From: ng0 @ 2016-11-16 12:27 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/video.scm (mps-youtube): Disable tests.
---
 gnu/packages/video.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 4329d20..1cb7a12 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1702,6 +1702,12 @@ Content System specification.")
         (base32
          "1s7h35yx6f0szf8mm8612ic913w3v05m2kwphjfcxnpq0ammhyci"))))
     (build-system python-build-system)
+    (arguments
+     ;; Tests need to be disabled until #556 upstream is fixed. It reads as if the
+     ;; test suite results differ depending on the country and also introduce
+     ;; non-determinism in the tests.
+     ;; https://github.com/mps-youtube/mps-youtube/issues/556
+     `(#:tests? #f))
     (propagated-inputs
      `(("python-pafy" ,python-pafy)
        ("python-pygobject" ,python-pygobject))) ; For mpris2 support
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] gnu: python-pafy: Disable tests.
  2016-11-16 12:27 [PATCH 1/2] gnu: python-pafy: Disable tests ng0
  2016-11-16 12:27 ` [PATCH 2/2] gnu: mps-youtube: " ng0
@ 2016-11-18 20:17 ` Leo Famulari
  1 sibling, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2016-11-18 20:17 UTC (permalink / raw)
  To: ng0; +Cc: guix-devel

On Wed, Nov 16, 2016 at 12:27:56PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-pafy): Disable tests.

Thanks, pushed!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] gnu: mps-youtube: Disable tests.
  2016-11-16 12:27 ` [PATCH 2/2] gnu: mps-youtube: " ng0
@ 2016-11-18 20:17   ` Leo Famulari
  0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2016-11-18 20:17 UTC (permalink / raw)
  To: ng0; +Cc: guix-devel

On Wed, Nov 16, 2016 at 12:27:57PM +0000, ng0 wrote:
> * gnu/packages/video.scm (mps-youtube): Disable tests.

Thanks for the helpful comment! Pushed!

> ---
>  gnu/packages/video.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 4329d20..1cb7a12 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1702,6 +1702,12 @@ Content System specification.")
>          (base32
>           "1s7h35yx6f0szf8mm8612ic913w3v05m2kwphjfcxnpq0ammhyci"))))
>      (build-system python-build-system)
> +    (arguments
> +     ;; Tests need to be disabled until #556 upstream is fixed. It reads as if the
> +     ;; test suite results differ depending on the country and also introduce
> +     ;; non-determinism in the tests.
> +     ;; https://github.com/mps-youtube/mps-youtube/issues/556
> +     `(#:tests? #f))
>      (propagated-inputs
>       `(("python-pafy" ,python-pafy)
>         ("python-pygobject" ,python-pygobject))) ; For mpris2 support
> -- 
> 2.10.2
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-18 20:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 12:27 [PATCH 1/2] gnu: python-pafy: Disable tests ng0
2016-11-16 12:27 ` [PATCH 2/2] gnu: mps-youtube: " ng0
2016-11-18 20:17   ` Leo Famulari
2016-11-18 20:17 ` [PATCH 1/2] gnu: python-pafy: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).