* [PATCH] Fix ardour and mod-host builds.
@ 2016-11-14 22:43 Ricardo Wurmus
2016-11-14 22:43 ` [PATCH] gnu: fftw: Build threads library Ricardo Wurmus
2016-11-15 8:03 ` [PATCH] Fix ardour and mod-host builds Efraim Flashner
0 siblings, 2 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2016-11-14 22:43 UTC (permalink / raw)
To: guix-devel
This patch requires quite a few rebuilds. It is needed to fix the build of
at least Ardour and mod-host.
Should this go to core-updates?
Ricardo Wurmus (1):
gnu: fftw: Build threads library.
gnu/packages/algebra.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.10.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gnu: fftw: Build threads library.
2016-11-14 22:43 [PATCH] Fix ardour and mod-host builds Ricardo Wurmus
@ 2016-11-14 22:43 ` Ricardo Wurmus
2016-11-15 10:13 ` Ludovic Courtès
2016-11-15 8:03 ` [PATCH] Fix ardour and mod-host builds Efraim Flashner
1 sibling, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2016-11-14 22:43 UTC (permalink / raw)
To: guix-devel
* gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
configure flags.
---
gnu/packages/algebra.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 8e9695d..e212775 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -544,7 +544,8 @@ a C program.")
"1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
(build-system gnu-build-system)
(arguments
- '(#:configure-flags '("--enable-shared" "--enable-openmp")
+ '(#:configure-flags
+ '("--enable-shared" "--enable-openmp" "--enable-threads")
#:phases (alist-cons-before
'build 'no-native
(lambda _
--
2.10.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ardour and mod-host builds.
2016-11-14 22:43 [PATCH] Fix ardour and mod-host builds Ricardo Wurmus
2016-11-14 22:43 ` [PATCH] gnu: fftw: Build threads library Ricardo Wurmus
@ 2016-11-15 8:03 ` Efraim Flashner
1 sibling, 0 replies; 6+ messages in thread
From: Efraim Flashner @ 2016-11-15 8:03 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Mon, Nov 14, 2016 at 11:43:41PM +0100, Ricardo Wurmus wrote:
> This patch requires quite a few rebuilds. It is needed to fix the build of
> at least Ardour and mod-host.
>
> Should this go to core-updates?
>
> Ricardo Wurmus (1):
> gnu: fftw: Build threads library.
>
> gnu/packages/algebra.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.10.1
>
Building the following 241 packages would ensure 444 dependent packages
are rebuilt:
I think we're going to have an intermediate branch for the 300-1200
rebuilds that shouldn't cause any breakages, and IMO this looks like
it's a perfect candidate for such a branch.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: fftw: Build threads library.
2016-11-14 22:43 ` [PATCH] gnu: fftw: Build threads library Ricardo Wurmus
@ 2016-11-15 10:13 ` Ludovic Courtès
2016-11-15 20:36 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-11-15 10:13 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <rekado@elephly.net> skribis:
> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
> configure flags.
> ---
> gnu/packages/algebra.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
> index 8e9695d..e212775 100644
> --- a/gnu/packages/algebra.scm
> +++ b/gnu/packages/algebra.scm
> @@ -544,7 +544,8 @@ a C program.")
> "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
> (build-system gnu-build-system)
> (arguments
> - '(#:configure-flags '("--enable-shared" "--enable-openmp")
> + '(#:configure-flags
> + '("--enable-shared" "--enable-openmp" "--enable-threads")
> #:phases (alist-cons-before
> 'build 'no-native
> (lambda _
LGTM!
Per
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
this is a perfect candidate for ‘staging’.
(In the meantime, if that helps, you could additionally create an FFTW
variant for use by Ardour, in master.)
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: fftw: Build threads library.
2016-11-15 10:13 ` Ludovic Courtès
@ 2016-11-15 20:36 ` Ricardo Wurmus
2016-11-16 21:23 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2016-11-15 20:36 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Ludovic Courtès <ludo@gnu.org> writes:
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
>> configure flags.
>> ---
>> gnu/packages/algebra.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
>> index 8e9695d..e212775 100644
>> --- a/gnu/packages/algebra.scm
>> +++ b/gnu/packages/algebra.scm
>> @@ -544,7 +544,8 @@ a C program.")
>> "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>> (build-system gnu-build-system)
>> (arguments
>> - '(#:configure-flags '("--enable-shared" "--enable-openmp")
>> + '(#:configure-flags
>> + '("--enable-shared" "--enable-openmp" "--enable-threads")
>> #:phases (alist-cons-before
>> 'build 'no-native
>> (lambda _
>
> LGTM!
>
> Per
> <https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
> this is a perfect candidate for ‘staging’.
Thanks for the reference. We don’t have a staging branch yet, as far as
I can tell. May I just push this commit to a new “staging” branch then?
> (In the meantime, if that helps, you could additionally create an FFTW
> variant for use by Ardour, in master.)
Yes, I’ll do that.
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: fftw: Build threads library.
2016-11-15 20:36 ` Ricardo Wurmus
@ 2016-11-16 21:23 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-11-16 21:23 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <rekado@elephly.net> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> * gnu/packages/algebra.scm (fftw)[arguments]: Add "--enable-threads" to
>>> configure flags.
>>> ---
>>> gnu/packages/algebra.scm | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
>>> index 8e9695d..e212775 100644
>>> --- a/gnu/packages/algebra.scm
>>> +++ b/gnu/packages/algebra.scm
>>> @@ -544,7 +544,8 @@ a C program.")
>>> "1kwbx92ps0r7s2mqy7lxbxanslxdzj7dp7r7gmdkzv1j8yqf3kwf"))))
>>> (build-system gnu-build-system)
>>> (arguments
>>> - '(#:configure-flags '("--enable-shared" "--enable-openmp")
>>> + '(#:configure-flags
>>> + '("--enable-shared" "--enable-openmp" "--enable-threads")
>>> #:phases (alist-cons-before
>>> 'build 'no-native
>>> (lambda _
>>
>> LGTM!
>>
>> Per
>> <https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>,
>> this is a perfect candidate for ‘staging’.
>
> Thanks for the reference. We don’t have a staging branch yet, as far as
> I can tell. May I just push this commit to a new “staging” branch then?
Yep! So the idea would be to freeze it in ~2 weeks (Nov. 30) and to
merge it in 3 weeks (Dec. 7). Let’s see if we can be disciplined. :-)
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-16 21:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14 22:43 [PATCH] Fix ardour and mod-host builds Ricardo Wurmus
2016-11-14 22:43 ` [PATCH] gnu: fftw: Build threads library Ricardo Wurmus
2016-11-15 10:13 ` Ludovic Courtès
2016-11-15 20:36 ` Ricardo Wurmus
2016-11-16 21:23 ` Ludovic Courtès
2016-11-15 8:03 ` [PATCH] Fix ardour and mod-host builds Efraim Flashner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).