From: Thomas Danckaert <post@thomasdanckaert.be>
To: leo@famulari.name
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add gctp
Date: Sat, 24 Sep 2016 21:49:56 +0200 (CEST) [thread overview]
Message-ID: <20160924.214956.2240292588360339390.post@thomasdanckaert.be> (raw)
In-Reply-To: <20160924010825.GA13078@jasmine>
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add gctp
Date: Fri, 23 Sep 2016 21:08:25 -0400
>> + (version "2.0")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
>
> The only thing I would like to change is this mismatch between the
> version and the tarball name. Can we call it version 2.0.0?
>
> Also, we should add a (file-name) field so that the downloaded tarball
> has "gctp" in the name.
>
> I can make these changes locally if you think they are okay.
Of course, go ahead!
Thanks for reviewing the patch(-es).
Thomas
next prev parent reply other threads:[~2016-09-24 19:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 12:40 [PATCH] Add gctp Thomas Danckaert
2016-06-18 1:39 ` Leo Famulari
2016-06-18 9:05 ` Thomas Danckaert
2016-06-21 6:35 ` Thomas Danckaert
2016-06-25 17:21 ` Leo Famulari
2016-06-27 19:07 ` Thomas Danckaert
2016-07-01 20:33 ` Leo Famulari
2016-07-07 7:40 ` Thomas Danckaert
2016-07-18 13:02 ` Ludovic Courtès
2016-07-18 21:47 ` Leo Famulari
2016-09-15 17:08 ` Thomas Danckaert
2016-09-24 1:08 ` Leo Famulari
2016-09-24 19:49 ` Thomas Danckaert [this message]
2016-09-27 17:38 ` Leo Famulari
-- strict thread matches above, loose matches on Subject: below --
2016-06-17 12:41 Thomas Danckaert
2016-06-17 9:29 Thomas Danckaert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924.214956.2240292588360339390.post@thomasdanckaert.be \
--to=post@thomasdanckaert.be \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).