From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Danckaert <post@thomasdanckaert.be>
Subject: Re: [PATCH] Add gctp
Date: Sat, 24 Sep 2016 21:49:56 +0200 (CEST)
Message-ID: <20160924.214956.2240292588360339390.post@thomasdanckaert.be>
References: <20160718214723.GA449@jasmine>
	<20160915.190808.526226800252619989.thomas.danckaert@gmail.com>
	<20160924010825.GA13078@jasmine>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <post@thomasdanckaert.be>) id 1bnsxm-0007A9-81
	for guix-devel@gnu.org; Sat, 24 Sep 2016 15:50:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <post@thomasdanckaert.be>) id 1bnsxh-0001Mp-Vs
	for guix-devel@gnu.org; Sat, 24 Sep 2016 15:50:17 -0400
Received: from s01.spamexperts.axc.nl ([159.253.0.153]:35204)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <post@thomasdanckaert.be>) id 1bnsxh-0001Hp-P4
	for guix-devel@gnu.org; Sat, 24 Sep 2016 15:50:13 -0400
In-Reply-To: <20160924010825.GA13078@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: leo@famulari.name
Cc: guix-devel@gnu.org

From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add gctp
Date: Fri, 23 Sep 2016 21:08:25 -0400

>> +    (version "2.0")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
> 
> The only thing I would like to change is this mismatch between the
> version and the tarball name. Can we call it version 2.0.0?
> 
> Also, we should add a (file-name) field so that the downloaded tarball
> has "gctp" in the name.
> 
> I can make these changes locally if you think they are okay.

Of course, go ahead!

Thanks for reviewing the patch(-es).

Thomas