unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
@ 2016-06-12 15:40 Danny Milosavljevic
  2016-06-13 20:59 ` Leo Famulari
  0 siblings, 1 reply; 7+ messages in thread
From: Danny Milosavljevic @ 2016-06-12 15:40 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/python.scm (python-wcwidth, python2-wcwidth): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b2d27ef..a35b0f6 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9126,3 +9126,33 @@ are optionally backed by a C extension built on librdkafka.")
 
 (define-public python2-pykafka
   (package-with-python2 python-pykafka))
+
+(define-public python-wcwidth
+ (package
+  (name "python-wcwidth")
+  (version "0.1.6")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "https://pypi.python.org/packages/"
+             "c2/d1/7689293086a8d5320025080cde0e3155b94ae0a7496fb89a3fbaa92c354a/"
+             "wcwidth-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "02wjrpf001gjdjsaxxbzcwfg19crlk2dbddayrfc2v06f53yrcyw"))))
+  (build-system python-build-system)
+  (home-page "https://github.com/jquast/wcwidth")
+  (synopsis
+    "Measures number of Terminal column cells of wide-character codes")
+  (description
+    "Measures number of Terminal column cells of wide-character codes")
+  (license license:expat)))
+
+(define-public python2-wcwidth
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-wcwidth)))
+    (native-inputs `(("python2-setuptools" ,python2-setuptools)))))

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-12 15:40 [PATCH] gnu: Add python-wcwidth and python2-wcwidth Danny Milosavljevic
@ 2016-06-13 20:59 ` Leo Famulari
  2016-06-14 12:13   ` Danny Milosavljevic
  0 siblings, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2016-06-13 20:59 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

On Sun, Jun 12, 2016 at 05:40:06PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-wcwidth, python2-wcwidth): New variables.

Thanks for the patch!

What do you think of the attached changes to the synopsis and
description?

[-- Attachment #2: python-wcwidth.diff --]
[-- Type: text/x-diff, Size: 1376 bytes --]

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3168de7..4c15771 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9197,18 +9197,19 @@ are optionally backed by a C extension built on librdkafka.")
       (uri (string-append
              "https://pypi.python.org/packages/"
              "c2/d1/7689293086a8d5320025080cde0e3155b94ae0a7496fb89a3fbaa92c354a/"
-             "wcwidth-"
-             version
-             ".tar.gz"))
+             "wcwidth-" version ".tar.gz"))
       (sha256
         (base32
           "02wjrpf001gjdjsaxxbzcwfg19crlk2dbddayrfc2v06f53yrcyw"))))
   (build-system python-build-system)
   (home-page "https://github.com/jquast/wcwidth")
   (synopsis
-    "Measures number of Terminal column cells of wide-character codes")
-  (description
-    "Measures number of Terminal column cells of wide-character codes")
+    "Measures number of terminal column cells of wide-character codes.")
+  (description "Wcwidth measures the number of terminal column cells of
+wide-character codes.  It is useful for those implementing a terminal emulator,
+or programs that carefully produce output to be interpreted by one.  It is a
+Python implementation of the @code{wcwidth} and @code{wcwidth} C functions
+specified in POSIX.1-2001 and POSIX.1-2008.")
   (license license:expat)))
 
 (define-public python2-wcwidth

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-13 20:59 ` Leo Famulari
@ 2016-06-14 12:13   ` Danny Milosavljevic
  2016-06-14 13:41     ` Leo Famulari
  0 siblings, 1 reply; 7+ messages in thread
From: Danny Milosavljevic @ 2016-06-14 12:13 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel, Danny Milosavljevic

On Mon, 13 Jun 2016 16:59:14 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Sun, Jun 12, 2016 at 05:40:06PM +0200, Danny Milosavljevic wrote:
> > * gnu/packages/python.scm (python-wcwidth, python2-wcwidth): New variables.  
> 
> Thanks for the patch!
> 
> What do you think of the attached changes to the synopsis and
> description?

Nice!

>@code{wcwidth} and @code{wcwidth}

Errrr

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-14 12:13   ` Danny Milosavljevic
@ 2016-06-14 13:41     ` Leo Famulari
  2016-06-14 23:15       ` Danny Milosavljevic
  0 siblings, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2016-06-14 13:41 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: guix-devel, Danny Milosavljevic

On Tue, Jun 14, 2016 at 02:13:32PM +0200, Danny Milosavljevic wrote:
> On Mon, 13 Jun 2016 16:59:14 -0400
> Leo Famulari <leo@famulari.name> wrote:
> 
> > On Sun, Jun 12, 2016 at 05:40:06PM +0200, Danny Milosavljevic wrote:
> > > * gnu/packages/python.scm (python-wcwidth, python2-wcwidth): New variables.  
> > 
> > Thanks for the patch!
> > 
> > What do you think of the attached changes to the synopsis and
> > description?
> 
> Nice!
> 
> >@code{wcwidth} and @code{wcwidth}
> 
> Errrr

I'm not sure how to interpret that :) Is it a negative reaction?

It's texinfo markup that allows the marked up text to be displayed "as
code", however you want to interpret that. I think it is monospaced in
some formats. In `guix package --show` it is quoted in a particular way.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-14 13:41     ` Leo Famulari
@ 2016-06-14 23:15       ` Danny Milosavljevic
  2016-06-15  1:52         ` Leo Famulari
  0 siblings, 1 reply; 7+ messages in thread
From: Danny Milosavljevic @ 2016-06-14 23:15 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel, Danny Milosavljevic

On Tue, 14 Jun 2016 09:41:01 -0400
Leo Famulari <leo@famulari.name> wrote:

> > >@code{wcwidth} and @code{wcwidth}  

Is that twice the same thing?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-14 23:15       ` Danny Milosavljevic
@ 2016-06-15  1:52         ` Leo Famulari
  2016-06-15 14:45           ` Leo Famulari
  0 siblings, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2016-06-15  1:52 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: guix-devel, Danny Milosavljevic

On Wed, Jun 15, 2016 at 01:15:37AM +0200, Danny Milosavljevic wrote:
> On Tue, 14 Jun 2016 09:41:01 -0400
> Leo Famulari <leo@famulari.name> wrote:
> 
> > > >@code{wcwidth} and @code{wcwidth}  
> 
> Is that twice the same thing?

Yes! :p

The second one should be wcswidth.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: Add python-wcwidth and python2-wcwidth.
  2016-06-15  1:52         ` Leo Famulari
@ 2016-06-15 14:45           ` Leo Famulari
  0 siblings, 0 replies; 7+ messages in thread
From: Leo Famulari @ 2016-06-15 14:45 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: guix-devel, Danny Milosavljevic

On Tue, Jun 14, 2016 at 09:52:01PM -0400, Leo Famulari wrote:
> On Wed, Jun 15, 2016 at 01:15:37AM +0200, Danny Milosavljevic wrote:
> > On Tue, 14 Jun 2016 09:41:01 -0400
> > Leo Famulari <leo@famulari.name> wrote:
> > 
> > > > >@code{wcwidth} and @code{wcwidth}  
> > 
> > Is that twice the same thing?
> 
> Yes! :p
> 
> The second one should be wcswidth.

Anyways, pushed as a44fd439dc! Thanks!

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-06-15 14:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-12 15:40 [PATCH] gnu: Add python-wcwidth and python2-wcwidth Danny Milosavljevic
2016-06-13 20:59 ` Leo Famulari
2016-06-14 12:13   ` Danny Milosavljevic
2016-06-14 13:41     ` Leo Famulari
2016-06-14 23:15       ` Danny Milosavljevic
2016-06-15  1:52         ` Leo Famulari
2016-06-15 14:45           ` Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).