[PATCH 1/3] gnu: Add arc-theme.

[PATCH 1/3] gnu: Add arc-theme.

[David Thompson]

* gnu/packages/gnome.scm (arc-theme): New variable.
---
 gnu/packages/gnome.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 8384c76..227dec1 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5182,3 +5182,36 @@ GNOME 3.  This includes things like the fonts used in user interface elements,
 alternative user interface themes, changes in window management behavior,
 GNOME Shell appearance and extension, etc.")
     (license license:gpl3+)))
+
+(define-public arc-theme
+  (package
+    (name "arc-theme")
+    (version "20160605")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/horst3180/arc-theme"
+                                  "/archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0sq2031xda8jn2ws0x2bvhq77jfh7xy0c3kg86v6vm2kbrrss7y6"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'bootstrap
+           (lambda _
+             (zero? (system* "autoreconf" "-vif")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+)))
+    (synopsis "A flat GTK theme with transparent elements")
+    (description "Arc is a flat theme with transparent elements for GTK 3, GTK
+2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments
+like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")
+    (home-page "https://github.com/horst3180/arc-theme")
+    ;; No "or later" language found.
+    (license license:gpl3)))
-- 
2.8.3

[PATCH 2/3] gnu: Add moka-icon-theme.

[David Thompson]

* gnu/packages/gnome.scm (moka-icon-theme): New variable.
---
 gnu/packages/gnome.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 227dec1..2ce1f18 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5215,3 +5215,38 @@ like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")
     (home-page "https://github.com/horst3180/arc-theme")
     ;; No "or later" language found.
     (license license:gpl3)))
+
+(define-public moka-icon-theme
+  (package
+    (name "moka-icon-theme")
+    (version "5.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/moka-project"
+                                  "/moka-icon-theme/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1lnk7p8dsd9xh6cgz5krvlcr457w8yl4m6p6s5c2g5narsjswzrm"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-makefile.am
+           (lambda _
+             (substitute* '("Makefile.am")
+               (("\\$\\(DESTDIR\\)/usr/share")
+                "$(datadir)"))
+             #t))
+         (add-after 'patch-makefile.am 'bootstrap
+           (lambda _
+             (zero? (system* "autoreconf" "-vif")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (synopsis "Moka icon theme")
+    (description "Moka is a stylized desktop icon set, designed to be clear,
+simple and consistent.")
+    (home-page "http://snwh.org/moka")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 3/3] gnu: Add arc-icon-theme.

[David Thompson]

* gnu/packages/gnome.scm (arc-icon-theme): New variable.
---
 gnu/packages/gnome.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 2ce1f18..a81dd0e 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5250,3 +5250,36 @@ like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")
 simple and consistent.")
     (home-page "http://snwh.org/moka")
     (license license:gpl3+)))
+
+(define-public arc-icon-theme
+  (package
+    (name "arc-icon-theme")
+    (version "20160605")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/horst3180/arc-icon-theme"
+                                  "/archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1npf0ki0j0llrw9wbffhxxa1cdms0q7b8xlg9m943dd9g7pgdm2p"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'bootstrap
+           (lambda _
+             (zero? (system* "autoreconf" "-vif")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    ;; When Arc is missing an icon, it looks in the Moka icon theme for it.
+    (propagated-inputs
+     `(("moka-icon-theme" ,moka-icon-theme)))
+    (synopsis "Arc icon theme")
+    (description "The Arc icon theme provides a set of icons matching the
+style of the Arc GTK theme.  Icons missing from the Arc theme are provided by
+the Moka icon theme.")
+    (home-page "https://github.com/horst3180/arc-icon-theme")
+    ;; No "or later" language found.
+    (license license:gpl3)))
-- 
2.8.3

Re: [PATCH 1/3] gnu: Add arc-theme.

[宋文武]

David Thompson <dthompson2@worcester.edu> writes:

> * gnu/packages/gnome.scm (arc-theme): New variable.

Cool, thanks!

> +    (inputs
> +     `(("gtk+" ,gtk+)))
> +    (synopsis "A flat GTK theme with transparent elements")
Drop the leading 'A'.

> +    (description "Arc is a flat theme with transparent elements for GTK 3, GTK
> +2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments
> +like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")

I think ".. for GTK+, with additional theme for window manager of GNOME,
Unity, ..." is better.

Re: [PATCH 1/3] gnu: Add arc-theme.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/gnome.scm (arc-theme): New variable.

[...]

> +    (synopsis "A flat GTK theme with transparent elements")

s/A flat GTK/Flat GTK+/

> +    (description "Arc is a flat theme with transparent elements for GTK 3, GTK
> +2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments
> +like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")

s/Gnome/GNOME/ s/GTK/GTK+/  :-)

Otherwise LGTM, thanks!

Ludo'.

Re: [PATCH 2/3] gnu: Add moka-icon-theme.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/gnome.scm (moka-icon-theme): New variable.

OK!

Re: [PATCH 3/3] gnu: Add arc-icon-theme.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/gnome.scm (arc-icon-theme): New variable.

[...]

> +    (home-page "https://github.com/horst3180/arc-icon-theme")
> +    ;; No "or later" language found.
> +    (license license:gpl3)))

Looking more closely (the same goes for the two other themes), it seems
there are no source file headers, because source files are SVGs, so in
effect, there’s no place where they could write “v3 only” or “v3 or any
later version”.

In that case, the license text prevails, and thus, we write it as
‘gpl3+’.

Does it make sense?

Otherwise LGTM, thanks!

Ludo’.

Re: [PATCH 1/3] gnu: Add arc-theme.

[Thompson, David]

On Fri, Jun 10, 2016 at 8:26 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> * gnu/packages/gnome.scm (arc-theme): New variable.
>
> [...]
>
>> +    (synopsis "A flat GTK theme with transparent elements")
>
> s/A flat GTK/Flat GTK+/
>
>> +    (description "Arc is a flat theme with transparent elements for GTK 3, GTK
>> +2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments
>> +like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.")
>
> s/Gnome/GNOME/ s/GTK/GTK+/  :-)
>
> Otherwise LGTM, thanks!

Pushed.  Thanks!

- Dave

Re: [PATCH 2/3] gnu: Add moka-icon-theme.

[Thompson, David]

On Fri, Jun 10, 2016 at 8:26 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> * gnu/packages/gnome.scm (moka-icon-theme): New variable.
>
> OK!

Pushed, thanks!

- Dave

Re: [PATCH 3/3] gnu: Add arc-icon-theme.

[Thompson, David]

On Fri, Jun 10, 2016 at 8:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> * gnu/packages/gnome.scm (arc-icon-theme): New variable.
>
> [...]
>
>> +    (home-page "https://github.com/horst3180/arc-icon-theme")
>> +    ;; No "or later" language found.
>> +    (license license:gpl3)))
>
> Looking more closely (the same goes for the two other themes), it seems
> there are no source file headers, because source files are SVGs, so in
> effect, there’s no place where they could write “v3 only” or “v3 or any
> later version”.
>
> In that case, the license text prevails, and thus, we write it as
> ‘gpl3+’.
>
> Does it make sense?
>
> Otherwise LGTM, thanks!

Makes sense!  Fixed and pushed.

- Dave