From: Leo Famulari <leo@famulari.name>
To: Kei Yamashita <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add wmbattery
Date: Tue, 5 Apr 2016 04:24:23 -0400 [thread overview]
Message-ID: <20160405082423.GA4775@jasmine> (raw)
In-Reply-To: <20160404170451.5e21f8f0@openmailbox.org>
On Mon, Apr 04, 2016 at 05:04:51PM -0400, Kei Yamashita wrote:
Thanks for the patch!
As suggested by Danny, please run `guix lint` on it.
+ (version "2.50")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://http.debian.net/debian/pool/main/w/wmbattery/\
+wmbattery_2.50.orig.tar.gz"))
Can you re-use the version variable in the uri? There are many examples
of how to do this in the 'gnu/packages' directory of the Guix source
code.
Also, can you add a comment explaining why we fetch the source from
Debian?
+ (delete 'check))))
Can you instead use the form '#:tests? #f', and add a comment explaining
why the tests are disabled? There are also examples of this in
'gnu/packages'.
Can you send an updated patch?
next prev parent reply other threads:[~2016-04-05 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 21:04 [PATCH] gnu: Add wmbattery Kei Yamashita
2016-04-04 22:42 ` Danny Milosavljevic
2016-04-05 8:24 ` Leo Famulari [this message]
2016-04-05 8:52 ` Alex Kost
2016-05-13 10:25 ` Danny Milosavljevic
2016-05-13 15:17 ` Joey Hess
2016-05-15 2:38 ` Kei Yamashita
2016-05-17 21:05 ` Ludovic Courtès
2016-05-17 22:58 ` Kei Kebreau
2016-05-18 13:35 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405082423.GA4775@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).