From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add wmbattery
Date: Tue, 5 Apr 2016 04:24:23 -0400
Message-ID: <20160405082423.GA4775@jasmine>
References: <20160404170451.5e21f8f0@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1anMHl-0004TZ-9J
	for guix-devel@gnu.org; Tue, 05 Apr 2016 04:24:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1anMHi-0005HY-FE
	for guix-devel@gnu.org; Tue, 05 Apr 2016 04:24:29 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:46670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1anMHi-0005HQ-BV
	for guix-devel@gnu.org; Tue, 05 Apr 2016 04:24:26 -0400
Content-Disposition: inline
In-Reply-To: <20160404170451.5e21f8f0@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Kei Yamashita <kei@openmailbox.org>
Cc: guix-devel@gnu.org

On Mon, Apr 04, 2016 at 05:04:51PM -0400, Kei Yamashita wrote:

Thanks for the patch!

As suggested by Danny, please run `guix lint` on it.

+    (version "2.50")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append
+		    "http://http.debian.net/debian/pool/main/w/wmbattery/\
+wmbattery_2.50.orig.tar.gz"))

Can you re-use the version variable in the uri? There are many examples
of how to do this in the 'gnu/packages' directory of the Guix source
code.

Also, can you add a comment explaining why we fetch the source from
Debian?

+                  (delete 'check))))

Can you instead use the form '#:tests? #f', and add a comment explaining
why the tests are disabled? There are also examples of this in
'gnu/packages'.

Can you send an updated patch?