* [PATCH 1/2] Add (guix build build-flags).
@ 2015-10-25 6:11 Alex Vong
0 siblings, 0 replies; 4+ messages in thread
From: Alex Vong @ 2015-10-25 6:11 UTC (permalink / raw)
To: guix-devel
From 1d7f488a8fafb7246b2f694de545c0d6842034dd Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Sat, 24 Oct 2015 23:47:26 +0800
Subject: [PATCH 1/2] Add (guix build build-flags).
A module to manipulate build flags, similar to dpkg-buildflags.
* guix/build/build-flags.scm: New file.
* Makefile.am (MODULES): Register it.
---
Makefile.am | 1 +
guix/build/build-flags.scm | 271
+++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 272
insertions(+) create mode 100644 guix/build/build-flags.scm
diff --git a/Makefile.am b/Makefile.am
index 1427203..fd3fe8f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -71,6 +71,7 @@ MODULES = \
guix/svn-download.scm \
guix/ui.scm \
guix/build/download.scm \
+ guix/build/build-flags.scm \
guix/build/cmake-build-system.scm \
guix/build/emacs-build-system.scm \
guix/build/git.scm \
diff --git a/guix/build/build-flags.scm b/guix/build/build-flags.scm
new file mode 100644
index 0000000..30a35a1
--- /dev/null
+++ b/guix/build/build-flags.scm
@@ -0,0 +1,271 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Alex Vong <alexvong1995@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or
(at +;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (guix build build-flags)
+ #:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-9)
+ #:export (flag-list
+ flag-list+
+ flag-list-
+ flag-list->string-list
+ default-flag-list
+ format-flag-list
+ fortify-flag-list
+ stackprotector-flag-list
+ stackprotectorstrong-flag-list
+ relro-flag-list
+ bindnow-flag-list
+ pie-flag-list
+ all-flag-list))
+
+;;; Commentary:
+;;;
+;;; Module to manipulate build flags, similar to dpkg-buildflags.
+;;;
+;;; Data structure <flag-list> is constructed by flag-list.
+;;; The constructor flag-list does something to its arguments,
+;;; such as trimming white-spaces, to ensure no two arguments mean the
same. +;;;
+;;; Here is an example:
+;;; (define default-flag-list
+;;; (flag-list
+;;; #:CFLAGS '("-O2" "-g")
+;;; #:LDFLAGS '("-lm" "-lpthread")))
+;;;
+;;; flag-list+ and flag-list- are analogous to
+;;; numeric + and - but operate on <flag-list>.
+;;;
+;;; flag-list->string-list converts <flag-list> into
+;;; configure-flags-compatible string-list.
+;;;
+;;; Code:
+
+
+;;; Pair up a symbol with a procedure so that we know
+;;; what identifier is bound to the procedure at macro-expand time.
+(define-record-type <identifier-procedure-pair>
+ (cons-identifier-procedure id proc)
+ identifier-procedure-pair?
+ (id identifier)
+ (proc procedure))
+
+(define-syntax define-record-type-with-accessor-list
+ (syntax-rules ()
+ "Macro to define a srfi-9 record
+with accessor list bound to accessor-list-name.
+"
+ ((_ record-name
+ (constructor-name field-name* ...)
+ predicate-name
+ accessor-list-name
+ (field-name accessor-name) ...)
+ (begin
+ (define-record-type record-name
+ (constructor-name field-name* ...)
+ predicate-name
+ (field-name accessor-name) ...)
+ (define accessor-list-name
+ `(,(cons-identifier-procedure 'accessor-name
+ accessor-name) ...))))))
+
+;;; define <flag-list> using define-record-type-with-accessor-list
macro +(define-record-type-with-accessor-list <flag-list>
+ (make-flag-list c-flags
+ cpp-flags
+ c++-flags
+ fc-flags
+ f-flags
+ gcj-flags
+ ld-flags
+ objc-flags
+ objc++-flags)
+ flag-list?
+ flag-list-accessor-list
+ (c-flags CFLAGS)
+ (cpp-flags CPPFLAGS)
+ (c++-flags CXXFLAGS)
+ (fc-flags FCFLAGS)
+ (f-flags FFLAGS)
+ (gcj-flags GCJFLAGS)
+ (ld-flags LDFLAGS)
+ (objc-flags OBJCFLAGS)
+ (objc++-flags OBJCXXFLAGS))
+
+
+(define-syntax define*-with-keyword-list
+ (syntax-rules ()
+ "Macro to define a procedure with keyword and default arguments
+only with keyword list bound to keyword-list-name.
+"
+ ((_ (proc-name keyword-list-name
+ (keyword default-val) ...)
+ body)
+ (begin
+ (define* (proc-name #:key
+ (keyword default-val) ...)
+ body)
+ (define keyword-list-name
+ (map symbol->keyword
+ '(keyword ...)))))))
+
+;;; Constructor for <flag-list>
+;;; with keyword list bound to flag-list-keyword-list.
+(define*-with-keyword-list (flag-list flag-list-keyword-list
+ (CFLAGS '())
+ (CPPFLAGS '())
+ (CXXFLAGS '())
+ (FCFLAGS '())
+ (FFLAGS '())
+ (GCJFLAGS '())
+ (LDFLAGS '())
+ (OBJCFLAGS '())
+ (OBJCXXFLAGS '()))
+ (apply make-flag-list
+ (map (lambda (string-list)
+ (map string-trim-both string-list))
+ (list CFLAGS
+ CPPFLAGS
+ CXXFLAGS
+ FCFLAGS
+ FFLAGS
+ GCJFLAGS
+ LDFLAGS
+ OBJCFLAGS
+ OBJCXXFLAGS))))
+
+(define (keyword-apply proc kw-list kw-arg-list by-position-arg-list)
+ "keyword-apply is inspired by the same-name procedure in Racket.
+It applies a procedure using keyword list and keyword argument list.
+"
+ (apply proc
+ (append (concatenate (zip kw-list
+ kw-arg-list))
+ by-position-arg-list)))
+
+
+(define (flag-list-operation lset-operation)
+ "Take a lset operation.
+Return a procedure that takes any number of <flag-list>
+and does the set operation on them for each flags respectively
+"
+ (define (list-of-string-list-operation list-of-string-list)
+ (apply lset-operation
+ `(,string=? ,@list-of-string-list)))
+ (lambda list-of-flag-list
+ (let ((flag-list-proc-list (map procedure
+ flag-list-accessor-list)))
+ (keyword-apply flag-list
+ flag-list-keyword-list
+ (map (lambda (proc)
+ (list-of-string-list-operation
+ (map proc list-of-flag-list)))
+ flag-list-proc-list)
+ '()))))
+
+;;; union any number of <flag-list> for each flags
+(define flag-list+
+ (flag-list-operation lset-union))
+
+;;; take the first <flag-list> and minus the union of the rest for
each flags +(define flag-list-
+ (flag-list-operation lset-difference))
+
+(define (flag-list->string-list flag-lst)
+ "Convert <flag-list> into configure-flags-compatible string list.
+"
+ (map (lambda (accessor)
+ (let ((id (identifier accessor))
+ (proc (procedure accessor)))
+ (string-append (symbol->string id)
+ "="
+ (string-join (proc flag-lst)))))
+ flag-list-accessor-list))
+
+
+;;; build flags used in dpkg-buildflags
+
+(define default-flag-list
+ (flag-list
+ #:CFLAGS '("-g" "-O2")
+ #:CXXFLAGS '("-g" "-O2")
+ #:FCFLAGS '("-g" "-O2")
+ #:FFLAGS '("-g" "-O2")
+ #:GCJFLAGS '("-g" "-O2")
+ #:OBJCFLAGS '("-g" "-O2")
+ #:OBJCXXFLAGS '("-g" "-O2")))
+
+(define format-flag-list
+ (flag-list
+ #:CFLAGS '("-Wformat" "-Werror=format-security")
+ #:CXXFLAGS '("-Wformat" "-Werror=format-security")
+ #:OBJCFLAGS '("-Wformat" "-Werror=format-security")
+ #:OBJCXXFLAGS '("-Wformat" "-Werror=format-security")))
+
+(define fortify-flag-list
+ (flag-list
+ #:CPPFLAGS '("-D_FORTIFY_SOURCE=2")))
+
+(define stackprotector-flag-list
+ (flag-list
+ #:CFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:CXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:FCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:FFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:GCJFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:OBJCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:OBJCXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")))
+
+(define stackprotectorstrong-flag-list
+ (flag-list
+ #:CFLAGS '("-fstack-protector-strong")
+ #:CXXFLAGS '("-fstack-protector-strong")
+ #:FCFLAGS '("-fstack-protector-strong")
+ #:FFLAGS '("-fstack-protector-strong")
+ #:GCJFLAGS '("-fstack-protector-strong")
+ #:OBJCFLAGS '("-fstack-protector-strong")
+ #:OBJCXXFLAGS '("-fstack-protector-strong")))
+
+(define relro-flag-list
+ (flag-list
+ #:LDFLAGS '("-Wl,-z,relro")))
+
+(define bindnow-flag-list
+ (flag-list
+ #:LDFLAGS '("-Wl,-z,now")))
+
+(define pie-flag-list
+ (flag-list
+ #:CFLAGS '("-fPIE")
+ #:CXXFLAGS '("-fPIE")
+ #:FCFLAGS '("-fPIE")
+ #:FFLAGS '("-fPIE")
+ #:GCJFLAGS '("-fPIE")
+ #:LDFLAGS '("-fPIE" "-pie")
+ #:OBJCFLAGS '("-fPIE")
+ #:OBJCXXFLAGS '("-fPIE")))
+
+(define all-flag-list
+ (flag-list+ default-flag-list
+ format-flag-list
+ fortify-flag-list
+ stackprotectorstrong-flag-list
+ relro-flag-list
+ bindnow-flag-list
+ pie-flag-list))
+
+;;; build-flags.scm ends here
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] Add (guix build build-flags).
@ 2015-10-31 13:56 Alex Vong
2015-11-05 21:55 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Alex Vong @ 2015-10-31 13:56 UTC (permalink / raw)
To: guix-devel
From 6ad35e245c374ff828f167bb3467ce68559ccefd Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Sat, 31 Oct 2015 19:44:13 +0800
Subject: [PATCH 1/2] Add (guix build build-flags).
A module to manipulate build flags, similar to dpkg-buildflags.
* guix/build/build-flags.scm: New file.
* Makefile.am (MODULES): Register it.
---
Makefile.am | 1 +
guix/build/build-flags.scm | 271 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 272 insertions(+)
create mode 100644 guix/build/build-flags.scm
diff --git a/Makefile.am b/Makefile.am
index b2ee324..c62cb8b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -71,6 +71,7 @@ MODULES = \
guix/svn-download.scm \
guix/ui.scm \
guix/build/download.scm \
+ guix/build/build-flags.scm \
guix/build/cmake-build-system.scm \
guix/build/emacs-build-system.scm \
guix/build/git.scm \
diff --git a/guix/build/build-flags.scm b/guix/build/build-flags.scm
new file mode 100644
index 0000000..30a35a1
--- /dev/null
+++ b/guix/build/build-flags.scm
@@ -0,0 +1,271 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Alex Vong <alexvong1995@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (guix build build-flags)
+ #:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-9)
+ #:export (flag-list
+ flag-list+
+ flag-list-
+ flag-list->string-list
+ default-flag-list
+ format-flag-list
+ fortify-flag-list
+ stackprotector-flag-list
+ stackprotectorstrong-flag-list
+ relro-flag-list
+ bindnow-flag-list
+ pie-flag-list
+ all-flag-list))
+
+;;; Commentary:
+;;;
+;;; Module to manipulate build flags, similar to dpkg-buildflags.
+;;;
+;;; Data structure <flag-list> is constructed by flag-list.
+;;; The constructor flag-list does something to its arguments,
+;;; such as trimming white-spaces, to ensure no two arguments mean the same.
+;;;
+;;; Here is an example:
+;;; (define default-flag-list
+;;; (flag-list
+;;; #:CFLAGS '("-O2" "-g")
+;;; #:LDFLAGS '("-lm" "-lpthread")))
+;;;
+;;; flag-list+ and flag-list- are analogous to
+;;; numeric + and - but operate on <flag-list>.
+;;;
+;;; flag-list->string-list converts <flag-list> into
+;;; configure-flags-compatible string-list.
+;;;
+;;; Code:
+
+
+;;; Pair up a symbol with a procedure so that we know
+;;; what identifier is bound to the procedure at macro-expand time.
+(define-record-type <identifier-procedure-pair>
+ (cons-identifier-procedure id proc)
+ identifier-procedure-pair?
+ (id identifier)
+ (proc procedure))
+
+(define-syntax define-record-type-with-accessor-list
+ (syntax-rules ()
+ "Macro to define a srfi-9 record
+with accessor list bound to accessor-list-name.
+"
+ ((_ record-name
+ (constructor-name field-name* ...)
+ predicate-name
+ accessor-list-name
+ (field-name accessor-name) ...)
+ (begin
+ (define-record-type record-name
+ (constructor-name field-name* ...)
+ predicate-name
+ (field-name accessor-name) ...)
+ (define accessor-list-name
+ `(,(cons-identifier-procedure 'accessor-name
+ accessor-name) ...))))))
+
+;;; define <flag-list> using define-record-type-with-accessor-list macro
+(define-record-type-with-accessor-list <flag-list>
+ (make-flag-list c-flags
+ cpp-flags
+ c++-flags
+ fc-flags
+ f-flags
+ gcj-flags
+ ld-flags
+ objc-flags
+ objc++-flags)
+ flag-list?
+ flag-list-accessor-list
+ (c-flags CFLAGS)
+ (cpp-flags CPPFLAGS)
+ (c++-flags CXXFLAGS)
+ (fc-flags FCFLAGS)
+ (f-flags FFLAGS)
+ (gcj-flags GCJFLAGS)
+ (ld-flags LDFLAGS)
+ (objc-flags OBJCFLAGS)
+ (objc++-flags OBJCXXFLAGS))
+
+
+(define-syntax define*-with-keyword-list
+ (syntax-rules ()
+ "Macro to define a procedure with keyword and default arguments
+only with keyword list bound to keyword-list-name.
+"
+ ((_ (proc-name keyword-list-name
+ (keyword default-val) ...)
+ body)
+ (begin
+ (define* (proc-name #:key
+ (keyword default-val) ...)
+ body)
+ (define keyword-list-name
+ (map symbol->keyword
+ '(keyword ...)))))))
+
+;;; Constructor for <flag-list>
+;;; with keyword list bound to flag-list-keyword-list.
+(define*-with-keyword-list (flag-list flag-list-keyword-list
+ (CFLAGS '())
+ (CPPFLAGS '())
+ (CXXFLAGS '())
+ (FCFLAGS '())
+ (FFLAGS '())
+ (GCJFLAGS '())
+ (LDFLAGS '())
+ (OBJCFLAGS '())
+ (OBJCXXFLAGS '()))
+ (apply make-flag-list
+ (map (lambda (string-list)
+ (map string-trim-both string-list))
+ (list CFLAGS
+ CPPFLAGS
+ CXXFLAGS
+ FCFLAGS
+ FFLAGS
+ GCJFLAGS
+ LDFLAGS
+ OBJCFLAGS
+ OBJCXXFLAGS))))
+
+(define (keyword-apply proc kw-list kw-arg-list by-position-arg-list)
+ "keyword-apply is inspired by the same-name procedure in Racket.
+It applies a procedure using keyword list and keyword argument list.
+"
+ (apply proc
+ (append (concatenate (zip kw-list
+ kw-arg-list))
+ by-position-arg-list)))
+
+
+(define (flag-list-operation lset-operation)
+ "Take a lset operation.
+Return a procedure that takes any number of <flag-list>
+and does the set operation on them for each flags respectively
+"
+ (define (list-of-string-list-operation list-of-string-list)
+ (apply lset-operation
+ `(,string=? ,@list-of-string-list)))
+ (lambda list-of-flag-list
+ (let ((flag-list-proc-list (map procedure
+ flag-list-accessor-list)))
+ (keyword-apply flag-list
+ flag-list-keyword-list
+ (map (lambda (proc)
+ (list-of-string-list-operation
+ (map proc list-of-flag-list)))
+ flag-list-proc-list)
+ '()))))
+
+;;; union any number of <flag-list> for each flags
+(define flag-list+
+ (flag-list-operation lset-union))
+
+;;; take the first <flag-list> and minus the union of the rest for each flags
+(define flag-list-
+ (flag-list-operation lset-difference))
+
+(define (flag-list->string-list flag-lst)
+ "Convert <flag-list> into configure-flags-compatible string list.
+"
+ (map (lambda (accessor)
+ (let ((id (identifier accessor))
+ (proc (procedure accessor)))
+ (string-append (symbol->string id)
+ "="
+ (string-join (proc flag-lst)))))
+ flag-list-accessor-list))
+
+
+;;; build flags used in dpkg-buildflags
+
+(define default-flag-list
+ (flag-list
+ #:CFLAGS '("-g" "-O2")
+ #:CXXFLAGS '("-g" "-O2")
+ #:FCFLAGS '("-g" "-O2")
+ #:FFLAGS '("-g" "-O2")
+ #:GCJFLAGS '("-g" "-O2")
+ #:OBJCFLAGS '("-g" "-O2")
+ #:OBJCXXFLAGS '("-g" "-O2")))
+
+(define format-flag-list
+ (flag-list
+ #:CFLAGS '("-Wformat" "-Werror=format-security")
+ #:CXXFLAGS '("-Wformat" "-Werror=format-security")
+ #:OBJCFLAGS '("-Wformat" "-Werror=format-security")
+ #:OBJCXXFLAGS '("-Wformat" "-Werror=format-security")))
+
+(define fortify-flag-list
+ (flag-list
+ #:CPPFLAGS '("-D_FORTIFY_SOURCE=2")))
+
+(define stackprotector-flag-list
+ (flag-list
+ #:CFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:CXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:FCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:FFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:GCJFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:OBJCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
+ #:OBJCXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")))
+
+(define stackprotectorstrong-flag-list
+ (flag-list
+ #:CFLAGS '("-fstack-protector-strong")
+ #:CXXFLAGS '("-fstack-protector-strong")
+ #:FCFLAGS '("-fstack-protector-strong")
+ #:FFLAGS '("-fstack-protector-strong")
+ #:GCJFLAGS '("-fstack-protector-strong")
+ #:OBJCFLAGS '("-fstack-protector-strong")
+ #:OBJCXXFLAGS '("-fstack-protector-strong")))
+
+(define relro-flag-list
+ (flag-list
+ #:LDFLAGS '("-Wl,-z,relro")))
+
+(define bindnow-flag-list
+ (flag-list
+ #:LDFLAGS '("-Wl,-z,now")))
+
+(define pie-flag-list
+ (flag-list
+ #:CFLAGS '("-fPIE")
+ #:CXXFLAGS '("-fPIE")
+ #:FCFLAGS '("-fPIE")
+ #:FFLAGS '("-fPIE")
+ #:GCJFLAGS '("-fPIE")
+ #:LDFLAGS '("-fPIE" "-pie")
+ #:OBJCFLAGS '("-fPIE")
+ #:OBJCXXFLAGS '("-fPIE")))
+
+(define all-flag-list
+ (flag-list+ default-flag-list
+ format-flag-list
+ fortify-flag-list
+ stackprotectorstrong-flag-list
+ relro-flag-list
+ bindnow-flag-list
+ pie-flag-list))
+
+;;; build-flags.scm ends here
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Add (guix build build-flags).
2015-10-31 13:56 Alex Vong
@ 2015-11-05 21:55 ` Ludovic Courtès
2015-12-25 15:38 ` Alex Vong
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2015-11-05 21:55 UTC (permalink / raw)
To: Alex Vong; +Cc: guix-devel
Alex Vong <alexvong1995@gmail.com> skribis:
> From 6ad35e245c374ff828f167bb3467ce68559ccefd Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Sat, 31 Oct 2015 19:44:13 +0800
> Subject: [PATCH 1/2] Add (guix build build-flags).
>
> A module to manipulate build flags, similar to dpkg-buildflags.
>
> * guix/build/build-flags.scm: New file.
> * Makefile.am (MODULES): Register it.
[...]
> +;;; Module to manipulate build flags, similar to dpkg-buildflags.
It doesn’t really help to refer to dpkg-buildflags, at least for me. ;-)
> +;;; Data structure <flag-list> is constructed by flag-list.
> +;;; The constructor flag-list does something to its arguments,
> +;;; such as trimming white-spaces, to ensure no two arguments mean the same.
> +;;;
> +;;; Here is an example:
> +;;; (define default-flag-list
> +;;; (flag-list
> +;;; #:CFLAGS '("-O2" "-g")
> +;;; #:LDFLAGS '("-lm" "-lpthread")))
> +;;;
> +;;; flag-list+ and flag-list- are analogous to
> +;;; numeric + and - but operate on <flag-list>.
> +;;;
> +;;; flag-list->string-list converts <flag-list> into
> +;;; configure-flags-compatible string-list.
How would we use flag lists?
The problem is that each build system has its own way to specify custom
flags, and some don’t even allow that. So being able to manipulate flag
lists is nice, but I’m afraid we wouldn’t be able to make much out of
them.
WDYT?
> +(define-syntax define-record-type-with-accessor-list
> + (syntax-rules ()
> + "Macro to define a srfi-9 record
> +with accessor list bound to accessor-list-name.
Is this really needed? Would ‘define-record-type*’ from (guix records)
do the job?
> +(define-record-type-with-accessor-list <flag-list>
> + (make-flag-list c-flags
> + cpp-flags
> + c++-flags
> + fc-flags
> + f-flags
> + gcj-flags
> + ld-flags
> + objc-flags
> + objc++-flags)
I’m not convinced we need to list all these flags, but again, that
depends on how we end up using it.
On one hand that’s already too many flags, and we’d be passing the same
options to all of them anyway–like -fstack-protector, -fPIE, etc.
On the other hand, it’s very much GCC- and autotool-centric.
[...]
> +(define fortify-flag-list
> + (flag-list
> + #:CPPFLAGS '("-D_FORTIFY_SOURCE=2")))
> +
> +(define stackprotector-flag-list
> + (flag-list
> + #:CFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:CXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:FCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:FFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:GCJFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:OBJCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
> + #:OBJCXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")))
> +
> +(define stackprotectorstrong-flag-list
> + (flag-list
> + #:CFLAGS '("-fstack-protector-strong")
> + #:CXXFLAGS '("-fstack-protector-strong")
> + #:FCFLAGS '("-fstack-protector-strong")
> + #:FFLAGS '("-fstack-protector-strong")
> + #:GCJFLAGS '("-fstack-protector-strong")
> + #:OBJCFLAGS '("-fstack-protector-strong")
> + #:OBJCXXFLAGS '("-fstack-protector-strong")))
I’ve been thinking we should experiment with these various options. The
way I’d do it now would be by running:
./configure x y z CPPFLAGS=-D_FORTIFY_SOURCE=2 CFLAGS=-fstack-protector
This would be just automatically added to #:configure-flags in
gnu-build-system.scm.
Of course, some packages would ignore them and others would break, but
that’s part of the game. It largely have to be approached on a
case-by-case basis.
Thoughts?
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Add (guix build build-flags).
2015-11-05 21:55 ` Ludovic Courtès
@ 2015-12-25 15:38 ` Alex Vong
0 siblings, 0 replies; 4+ messages in thread
From: Alex Vong @ 2015-12-25 15:38 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
ludo@gnu.org (Ludovic Courtès) writes:
Hi,
This is an old thread, but I am still unclear of something, so I will
reply.
> Alex Vong <alexvong1995@gmail.com> skribis:
>
>> From 6ad35e245c374ff828f167bb3467ce68559ccefd Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Sat, 31 Oct 2015 19:44:13 +0800
>> Subject: [PATCH 1/2] Add (guix build build-flags).
>>
>> A module to manipulate build flags, similar to dpkg-buildflags.
>>
>> * guix/build/build-flags.scm: New file.
>> * Makefile.am (MODULES): Register it.
>
> [...]
>
>> +;;; Module to manipulate build flags, similar to dpkg-buildflags.
>
> It doesn’t really help to refer to dpkg-buildflags, at least for me. ;-)
>
Sure, I should have elaborated more on it. What I am looking for are
ways to avoid repeating a lot of flags in different packages, something
like `use this set of flags, please'. For example, in Debian, if you
type
$ dpkg-buildflags --get CFLAGS
you get
-g -O2 -fstack-protector-strong -Wformat -Werror=format-security
which are thr default flags to be exported during package
build. Moroever, maintainer can alter the default behaviour by setting
DEB_BUILD_MAINT_OPTIONS. For example,
$ DEB_BUILD_MAINT_OPTIONS=hardening=+all dpkg-buildflags --get CFLAGS
will return
-g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security
>> +;;; Data structure <flag-list> is constructed by flag-list.
>> +;;; The constructor flag-list does something to its arguments,
>> +;;; such as trimming white-spaces, to ensure no two arguments mean the same.
>> +;;;
>> +;;; Here is an example:
>> +;;; (define default-flag-list
>> +;;; (flag-list
>> +;;; #:CFLAGS '("-O2" "-g")
>> +;;; #:LDFLAGS '("-lm" "-lpthread")))
>> +;;;
>> +;;; flag-list+ and flag-list- are analogous to
>> +;;; numeric + and - but operate on <flag-list>.
>> +;;;
>> +;;; flag-list->string-list converts <flag-list> into
>> +;;; configure-flags-compatible string-list.
>
> How would we use flag lists?
>
> The problem is that each build system has its own way to specify custom
> flags, and some don’t even allow that. So being able to manipulate flag
> lists is nice, but I’m afraid we wouldn’t be able to make much out of
> them.
>
> WDYT?
>
>> +(define-syntax define-record-type-with-accessor-list
>> + (syntax-rules ()
>> + "Macro to define a srfi-9 record
>> +with accessor list bound to accessor-list-name.
>
> Is this really needed? Would ‘define-record-type*’ from (guix records)
> do the job?
>
>> +(define-record-type-with-accessor-list <flag-list>
>> + (make-flag-list c-flags
>> + cpp-flags
>> + c++-flags
>> + fc-flags
>> + f-flags
>> + gcj-flags
>> + ld-flags
>> + objc-flags
>> + objc++-flags)
>
> I’m not convinced we need to list all these flags, but again, that
> depends on how we end up using it.
>
> On one hand that’s already too many flags, and we’d be passing the same
> options to all of them anyway–like -fstack-protector, -fPIE, etc.
>
> On the other hand, it’s very much GCC- and autotool-centric.
>
> [...]
>
>> +(define fortify-flag-list
>> + (flag-list
>> + #:CPPFLAGS '("-D_FORTIFY_SOURCE=2")))
>> +
>> +(define stackprotector-flag-list
>> + (flag-list
>> + #:CFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:CXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:FCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:FFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:GCJFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:OBJCFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")
>> + #:OBJCXXFLAGS '("-fstack-protector" "--param=ssp-buffer-size=4")))
>> +
>> +(define stackprotectorstrong-flag-list
>> + (flag-list
>> + #:CFLAGS '("-fstack-protector-strong")
>> + #:CXXFLAGS '("-fstack-protector-strong")
>> + #:FCFLAGS '("-fstack-protector-strong")
>> + #:FFLAGS '("-fstack-protector-strong")
>> + #:GCJFLAGS '("-fstack-protector-strong")
>> + #:OBJCFLAGS '("-fstack-protector-strong")
>> + #:OBJCXXFLAGS '("-fstack-protector-strong")))
>
> I’ve been thinking we should experiment with these various options. The
> way I’d do it now would be by running:
>
> ./configure x y z CPPFLAGS=-D_FORTIFY_SOURCE=2 CFLAGS=-fstack-protector
>
> This would be just automatically added to #:configure-flags in
> gnu-build-system.scm.
>
> Of course, some packages would ignore them and others would break, but
> that’s part of the game. It largely have to be approached on a
> case-by-case basis.
>
Yes, I grep for `fstack-protector-strong' in the guix code base and no
matches are found. It appears no packages are setting this flag
currently. I think this flag (perhaps also a couple others) should be
set by default since they help protect against buffer overflow
<https://en.wikipedia.org/wiki/Buffer_overflow_protection>.
> Thoughts?
>
> Ludo’.
How do you people think?
Cheers,
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-25 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-25 6:11 [PATCH 1/2] Add (guix build build-flags) Alex Vong
-- strict thread matches above, loose matches on Subject: below --
2015-10-31 13:56 Alex Vong
2015-11-05 21:55 ` Ludovic Courtès
2015-12-25 15:38 ` Alex Vong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).