[PATCH 2/2] gnu: Add ruby-simplecov.

[PATCH 2/2] gnu: Add ruby-simplecov.

[Pjotr Prins]

* gnu/packages/ruby.scm (ruby-simplecov): New variable.
---
 gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 539b00b..2f7f89c 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1147,6 +1147,34 @@ Ruby objects in a snap.")
     (home-page "https://ms-ati.github.io/docile/")
     (license license:expat)))
 
+(define-public ruby-simplecov
+(package
+  (name "ruby-simplecov")
+  (version "0.10.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (rubygems-uri "simplecov" version))
+      (sha256
+        (base32
+          "1q2iq2vgrdvvla5y907gkmqx6ry2qvnvc7a90hlcbwgp1w0sv6z4"))))
+  (build-system ruby-build-system)
+  (propagated-inputs
+    `(("ruby-docile" ,ruby-docile)
+      ("ruby-json" ,ruby-json)))
+    (arguments
+     '(#:tests? #f)) ; needs github-markup, among others
+  (synopsis "Code coverage for Ruby")
+  (description "Code coverage analysis tool for Ruby.  It uses Ruby's
+built-in Coverage library to gather code coverage data, but makes
+processing its results much easier by providing a clean API to filter,
+group, merge, format, and display those results, giving you a complete
+code coverage suite that can be set up with just a couple lines of
+code.
+")
+  (home-page "http://github.com/colszowka/simplecov")
+  (license license:expat)))
+
 (define-public ruby-gherkin3
   (package
     (name "ruby-gherkin3")
-- 
2.4.3

Re: [PATCH 2/2] gnu: Add ruby-simplecov.

[Ricardo Wurmus]

Hi Pjotr,

> * gnu/packages/ruby.scm (ruby-simplecov): New variable.

[...]

> +  (propagated-inputs
> +    `(("ruby-docile" ,ruby-docile)
> +      ("ruby-json" ,ruby-json)))
> +    (arguments
> +     '(#:tests? #f)) ; needs github-markup, among others
> +  (synopsis "Code coverage for Ruby")

I find it very surprising to see only “docile” and “json” as inputs and
not “ruby-simplecov-html”.  According to
https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
dependency.

With my Ruby packages I’ve been closely following the dependencies as
they are declared on rubygems.org.

I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
minutes ago, so maybe you could update your patch and add it as an
input.

> +  (description "Code coverage analysis tool for Ruby.  It uses Ruby's
> +built-in Coverage library to gather code coverage data, but makes
> +processing its results much easier by providing a clean API to filter,
> +group, merge, format, and display those results, giving you a complete
> +code coverage suite that can be set up with just a couple lines of
> +code.
> +")

The closing quote and the closing parenthesis should be on the same line
as the period.  The rest looks good to me.

~~ Ricardo

Re: [PATCH 2/2] gnu: Add ruby-simplecov.

[Pjotr Prins]

The dependency is only for those cases that use HTML output. I am
using it for cucumber which don't needs it. Feel free to put in the
dependency. And push it.

Pj.


On Wed, Sep 16, 2015 at 11:34:18AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
> 
> > * gnu/packages/ruby.scm (ruby-simplecov): New variable.
> 
> [...]
> 
> > +  (propagated-inputs
> > +    `(("ruby-docile" ,ruby-docile)
> > +      ("ruby-json" ,ruby-json)))
> > +    (arguments
> > +     '(#:tests? #f)) ; needs github-markup, among others
> > +  (synopsis "Code coverage for Ruby")
> 
> I find it very surprising to see only “docile” and “json” as inputs and
> not “ruby-simplecov-html”.  According to
> https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
> dependency.
> 
> With my Ruby packages I’ve been closely following the dependencies as
> they are declared on rubygems.org.
> 
> I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
> minutes ago, so maybe you could update your patch and add it as an
> input.
> 
> > +  (description "Code coverage analysis tool for Ruby.  It uses Ruby's
> > +built-in Coverage library to gather code coverage data, but makes
> > +processing its results much easier by providing a clean API to filter,
> > +group, merge, format, and display those results, giving you a complete
> > +code coverage suite that can be set up with just a couple lines of
> > +code.
> > +")
> 
> The closing quote and the closing parenthesis should be on the same line
> as the period.  The rest looks good to me.
> 
> ~~ Ricardo
> 

--