From: Andreas Enge <andreas@enge.fr>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sat, 1 Nov 2014 17:59:50 +0100 [thread overview]
Message-ID: <20141101165950.GA10580@debian> (raw)
In-Reply-To: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Hello!
On Sat, Nov 01, 2014 at 11:48:46AM -0400, David Thompson wrote:
> + (uri (string-append "mirror://sourceforge/freeimage/Source%20Distribution/"
> + version "/FreeImage"
> + (string-join (string-split version #\.) "")
> + ".zip"))
This looks a bit longer than the 80 characters limit.
> + 'unpack
> + (lambda* (#:key source #:allow-other-keys)
> + (and (zero? (system* "unzip" source))
> + (chdir "FreeImage")))
I wonder if this should not be moved to the standard unpack phase. Can we
determine the file format and use the appropriate tool, unzip or tar,
automatically? (Assuming that there are no .tar.zip out there, of course.)
Andreas
next prev parent reply other threads:[~2014-11-01 17:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:48 [PATCH] gnu: Add freeimage David Thompson
2014-11-01 16:59 ` Andreas Enge [this message]
2014-11-01 17:21 ` David Thompson
2014-11-02 17:26 ` Ludovic Courtès
2014-11-02 17:35 ` David Thompson
2014-11-02 17:46 ` Andreas Enge
2014-11-02 17:55 ` David Thompson
2014-11-02 21:10 ` Andreas Enge
2014-11-02 21:38 ` David Thompson
2014-11-03 9:00 ` Ludovic Courtès
2014-11-03 9:29 ` Andreas Enge
2014-11-03 20:28 ` Ludovic Courtès
2014-11-03 23:29 ` David Thompson
2014-11-04 9:50 ` Ludovic Courtès
2014-11-05 3:12 ` David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101165950.GA10580@debian \
--to=andreas@enge.fr \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).