From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sat, 1 Nov 2014 17:59:50 +0100
Message-ID: <20141101165950.GA10580@debian>
References: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1Xkc1z-0004oU-UD
	for guix-devel@gnu.org; Sat, 01 Nov 2014 13:00:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1Xkc1s-0007yG-BV
	for guix-devel@gnu.org; Sat, 01 Nov 2014 13:00:03 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:55196)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1Xkc1s-0007y7-0i
	for guix-devel@gnu.org; Sat, 01 Nov 2014 12:59:56 -0400
Content-Disposition: inline
In-Reply-To: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

Hello!

On Sat, Nov 01, 2014 at 11:48:46AM -0400, David Thompson wrote:
> +            (uri (string-append "mirror://sourceforge/freeimage/Source%20Distribution/"
> +                                version "/FreeImage"
> +                                (string-join (string-split version #\.) "")
> +                                ".zip"))

This looks a bit longer than the 80 characters limit.

> +                'unpack
> +                (lambda* (#:key source #:allow-other-keys)
> +                  (and (zero? (system* "unzip" source))
> +                       (chdir "FreeImage")))

I wonder if this should not be moved to the standard unpack phase. Can we
determine the file format and use the appropriate tool, unzip or tar,
automatically? (Assuming that there are no .tar.zip out there, of course.)

Andreas