Re: 01/01: gnu: ncmpcpp: Enable taglib support.

Re: 01/01: gnu: ncmpcpp: Enable taglib support.

[Ludovic Courtès]

Howdy!

Paul <paul@denknerd.org> skribis:

> commit cd77777602af48a32466d8d720a6c70a89721607
> Author: Paul van der Walt <paul@denknerd.org>
> Date:   Sat Mar 7 13:40:40 2015 +0100
>
>     gnu: ncmpcpp: Enable taglib support.
>     
>     * gnu/packages/mpd.scm (ncmpcpp): Add --with-taglib configure flag.

[...]

> diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
> index 2313b30..2f9ad72 100644
> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm
> @@ -196,10 +196,11 @@ terminal using ncurses.")
>       `(("pkg-config" ,pkg-config)
>         ("automake" ,automake)
>         ("autoconf" ,autoconf)
> -       ("libtool" ,libtool)))
> +       ("libtool" ,libtool)
> +       ("taglib" ,taglib)))

‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the
distinction between the two is for when cross-compiling: ‘native-inputs’
are things that need to be run on the machine that compiles, whereas
‘inputs’ is code to run on the target machine.)

Could you adjust accordingly?

Thanks,
Ludo’.

Re: 01/01: gnu: ncmpcpp: Enable taglib support.

[Paul van der Walt]

On 2015-03-08 at 22:30, quoth Ludovic Courtès:
>> +       ("taglib" ,taglib)))
>
> ‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the
> distinction between the two is for when cross-compiling: ‘native-inputs’
> are things that need to be run on the machine that compiles, whereas
> ‘inputs’ is code to run on the target machine.)
>
> Could you adjust accordingly?

Argh, of course you're right -- that was purely me having a fuzzy
lack-of-attention moment... Sorry about that, correcting now.

p.

[PATCH] gnu: ncmpcpp: Move taglib from native-inputs.

[Paul van der Walt]

* gnu/packages/mpd.scm (ncmpcpp): Fixup badly-placed taglib input.
---
 gnu/packages/mpd.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 2f9ad72..f89d3ed 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -191,13 +191,13 @@ terminal using ncurses.")
     (inputs `(("libmpdclient" ,libmpdclient)
               ("boost"  ,boost)
               ("readline" ,readline)
-              ("ncurses" ,ncurses)))
+              ("ncurses" ,ncurses)
+              ("taglib" ,taglib)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("automake" ,automake)
        ("autoconf" ,autoconf)
-       ("libtool" ,libtool)
-       ("taglib" ,taglib)))
+       ("libtool" ,libtool)))
     (arguments
      '(#:configure-flags
        '("BOOST_LIB_SUFFIX=" "--with-taglib")
-- 
2.3.1

Re: 01/01: gnu: ncmpcpp: Enable taglib support.

[Ludovic Courtès]

Paul van der Walt <paul@denknerd.org> skribis:

> On 2015-03-08 at 22:30, quoth Ludovic Courtès:
>>> +       ("taglib" ,taglib)))
>>
>> ‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the
>> distinction between the two is for when cross-compiling: ‘native-inputs’
>> are things that need to be run on the machine that compiles, whereas
>> ‘inputs’ is code to run on the target machine.)
>>
>> Could you adjust accordingly?
>
> Argh, of course you're right -- that was purely me having a fuzzy
> lack-of-attention moment... Sorry about that, correcting now.

No problem!

Paul van der Walt <paul@denknerd.org> skribis:

> * gnu/packages/mpd.scm (ncmpcpp): Fixup badly-placed taglib input.

Rather “Move TAGLIB from ‘native-inputs’ to ‘inputs’.”

Please push, thanks!

Ludo’.