[PATCH] gnu: gst-plugins-good: Enable more plugins (I hope I have the commit message format right this time.)

[PATCH] gnu: gst-plugins-good: Enable more plugins (I hope I have the commit message format right this time.)

[John Darrington]

* gnu/packages/gstreamer.scm (gst-plugins-good): New inputs:
  cairo, gdk-pixbuf, flac, speex, libogg, libx11, zlib, libpng, libjpeg,
  libXext, libxv, pulseaudio
---
 gnu/packages/gstreamer.scm |   26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index aeccf7a..003b78a 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -28,8 +28,10 @@
   #:use-module (gnu packages flex)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages pkg-config)
@@ -155,22 +157,38 @@ for the GStreamer multimedia library.")
     (source
      (origin
       (method url-fetch)
-      (uri (string-append "http://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-"
-                          version ".tar.xz"))
+      (uri (string-append 
+            "http://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-"
+            version ".tar.xz"))
       (sha256
        (base32
         "1bi8ci0jssi8bsa7wbmqcwphl579vvxpshn2qnaggiha13b440y6"))))
     (build-system gnu-build-system)
     (inputs
      `(("glib" ,glib)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf)
+       ("flac" ,flac)
+       ("speex" ,speex)
+       ("libogg" ,libogg) ;; should be a propagated input of the above
+       ("libx11" ,libx11)
+       ("zlib" ,zlib)
+       ("libpng" ,libpng)
+       ("libjpeg" ,libjpeg)
+       ("libXext" ,libxext)
+       ("libxv" ,libxv)
+       ("pulseaudio" ,pulseaudio)
        ("gstreamer" ,gstreamer)))
     (native-inputs
       `(("pkg-config" ,pkg-config)
         ("glib" ,glib "bin")
         ("gst-plugins-base" ,gst-plugins-base)
         ("python-wrapper" ,python-wrapper)))
-    (arguments
-     `(#:tests? #f))
+   (arguments
+    `(#:configure-flags (list "--disable-osx_audio" 
+                              "--disable-osx_video"
+                              "--disable-directsound"
+                              "--disable-waveform")))
     (home-page "http://gstreamer.freedesktop.org/")
     (synopsis
      "Plugins for the GStreamer multimedia library")
-- 
1.7.10.4

Re: [PATCH] gnu: gst-plugins-good: Enable more plugins (I hope I have the commit message format right this time.)

[Ludovic Courtès]

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/gstreamer.scm (gst-plugins-good): New inputs:
>   cairo, gdk-pixbuf, flac, speex, libogg, libx11, zlib, libpng, libjpeg,
>   libXext, libxv, pulseaudio

LGTM.  With a period at the end of the commit message, it’ll be
perfect.  :-)

Thanks,
Ludo’.