From: Eric Bavier <bavier@member.fsf.org>
To: ludo@gnu.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: perl: Fix autosplitting of 0-time source.
Date: Thu, 10 Sep 2015 12:13:51 -0500 [thread overview]
Message-ID: <1388b77cddec078a96ab29341cfc9ee4@openmailbox.org> (raw)
In-Reply-To: <87zj0u1dm2.fsf@gnu.org>
On 2015-09-10 10:46, ludo@gnu.org wrote:
> ericbavier@openmailbox.org skribis:
>
>> From: Eric Bavier <bavier@member.fsf.org>
>>
>> * gnu/packages/patches/perl-autosplit-default-time.patch: New patch.
>> * gnu/packages/perl.scm (perl): Use it.
>> * gnu-system.am (dist_patch_DATA): Add it.
>
> Good catch, OK for ‘core-updates’. (It’s the 2nd case where we see
> assumptions about the range of an mtime.)
Ok, will push to 'core-updates'.
>> +AutoSplit will fail to create an index for files whose modification
>> time is 0
>> +because its default time for a non-existent index is 1. Set this
>> default time
>> +to -1 instead.
>
> What is the index used for?
AutoSplit uses the 'autosplit.ix' index files to catalog the file
locations of split functions, as well as a timestamp on the last time
the module was split, as far as I understand. The AutoLoader module
looks for these indices and emits a non-fatal but nonetheless
scary-looking warning of their non-existence at runtime, which is what
alerted me to the issue.
`~Eric
prev parent reply other threads:[~2015-09-10 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 8:48 [PATCH] gnu: perl: Fix autosplitting of 0-time source ericbavier
2015-09-10 15:46 ` Ludovic Courtès
2015-09-10 17:13 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388b77cddec078a96ab29341cfc9ee4@openmailbox.org \
--to=bavier@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).