From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH] gnu: perl: Fix autosplitting of 0-time source.
Date: Thu, 10 Sep 2015 12:13:51 -0500
Message-ID: <1388b77cddec078a96ab29341cfc9ee4@openmailbox.org>
References: <1441874926-1261-1-git-send-email-ericbavier@openmailbox.org>
	<87zj0u1dm2.fsf@gnu.org>
Reply-To: bavier@member.fsf.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50579)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1Za5QH-0007bJ-E7
	for guix-devel@gnu.org; Thu, 10 Sep 2015 13:14:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1Za5QD-0004hT-96
	for guix-devel@gnu.org; Thu, 10 Sep 2015 13:14:09 -0400
In-Reply-To: <87zj0u1dm2.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ludo@gnu.org
Cc: guix-devel@gnu.org

On 2015-09-10 10:46, ludo@gnu.org wrote:
> ericbavier@openmailbox.org skribis:
>=20
>> From: Eric Bavier <bavier@member.fsf.org>
>>=20
>> * gnu/packages/patches/perl-autosplit-default-time.patch: New patch.
>> * gnu/packages/perl.scm (perl): Use it.
>> * gnu-system.am (dist_patch_DATA): Add it.
>=20
> Good catch, OK for =E2=80=98core-updates=E2=80=99.  (It=E2=80=99s the 2=
nd case where we see
> assumptions about the range of an mtime.)

Ok, will push to 'core-updates'.

>> +AutoSplit will fail to create an index for files whose modification=20
>> time is 0
>> +because its default time for a non-existent index is 1.  Set this=20
>> default time
>> +to -1 instead.
>=20
> What is the index used for?

AutoSplit uses the 'autosplit.ix' index files to catalog the file=20
locations of split functions, as well as a timestamp on the last time=20
the module was split, as far as I understand.  The AutoLoader module=20
looks for these indices and emits a non-fatal but nonetheless=20
scary-looking warning of their non-existence at runtime, which is what=20
alerted me to the issue.

`~Eric