unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#56895: rust-brotli-sys bundles (insecure!) brotli
@ 2022-08-02 18:06 Maxime Devos
  2022-08-02 18:13 ` Maxime Devos
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Devos @ 2022-08-02 18:06 UTC (permalink / raw)
  To: 56895


[-- Attachment #1.1.1: Type: text/plain, Size: 550 bytes --]

I noticed rust-brotli-sys bundles brotli: 
<https://github.com/bitemyapp/brotli2-rs/blob/master/brotli-sys/build.rs#L16>.

The version it bundles is apparently insecure: 
<https://github.com/bitemyapp/brotli2-rs/issues/45>

As mentioned at <https://github.com/actix/actix-web/issues/2537>, there 
have been multiple PR updating it to new PR but they were abandoned, so 
it appears we have to remove rust-brotli-sys entirely (in favour of 
rust-brotli?) or merge one of them (or better: unbundle) things on our own.

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#56895: rust-brotli-sys bundles (insecure!) brotli
  2022-08-02 18:06 bug#56895: rust-brotli-sys bundles (insecure!) brotli Maxime Devos
@ 2022-08-02 18:13 ` Maxime Devos
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Devos @ 2022-08-02 18:13 UTC (permalink / raw)
  To: Nicolas Goaziou, 56895


[-- Attachment #1.1.1: Type: text/plain, Size: 232 bytes --]

Friendly reminder to the original patch author and committer (*) to 
check for bundling during review.

(*) 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=52cc16b38b1b01b2bb354ed5510120856de15d39

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-02 18:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 18:06 bug#56895: rust-brotli-sys bundles (insecure!) brotli Maxime Devos
2022-08-02 18:13 ` Maxime Devos

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).