* bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS @ 2017-12-22 17:58 Martin Castillo 2017-12-22 21:06 ` Ludovic Courtès 0 siblings, 1 reply; 5+ messages in thread From: Martin Castillo @ 2017-12-22 17:58 UTC (permalink / raw) To: 29814 guix/util.scm:(arguments-from-envirenment-variable) uses char-set:graphic to split the string. this makes it impossible to pass spaces in the arguments. This makes it impossible to pass more than one substitute-url via the environment. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS 2017-12-22 17:58 bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS Martin Castillo @ 2017-12-22 21:06 ` Ludovic Courtès 2017-12-23 3:36 ` Mark H Weaver 2017-12-27 16:37 ` Martin Castillo 0 siblings, 2 replies; 5+ messages in thread From: Ludovic Courtès @ 2017-12-22 21:06 UTC (permalink / raw) To: Martin Castillo; +Cc: 29814 Martin Castillo <castilma@uni-bremen.de> skribis: > guix/util.scm:(arguments-from-envirenment-variable) uses > char-set:graphic to split the string. this makes it impossible to pass > spaces in the arguments. > > This makes it impossible to pass more than one substitute-url via the > environment. Yes, this is annoying. I think --substitute-urls (plural) was misguided. Instead we should instead have --substitute-url (singular), which could be repeated several times. That would solve the troubles with spaces. During a transition period we could keep accepting --substitute-urls. WDYT? Ludo’. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS 2017-12-22 21:06 ` Ludovic Courtès @ 2017-12-23 3:36 ` Mark H Weaver 2017-12-23 14:14 ` Ludovic Courtès 2017-12-27 16:37 ` Martin Castillo 1 sibling, 1 reply; 5+ messages in thread From: Mark H Weaver @ 2017-12-23 3:36 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 29814 ludo@gnu.org (Ludovic Courtès) writes: > Martin Castillo <castilma@uni-bremen.de> skribis: > >> guix/util.scm:(arguments-from-envirenment-variable) uses >> char-set:graphic to split the string. this makes it impossible to pass >> spaces in the arguments. >> >> This makes it impossible to pass more than one substitute-url via the >> environment. > > Yes, this is annoying. I think --substitute-urls (plural) was > misguided. Instead we should instead have --substitute-url (singular), > which could be repeated several times. That would solve the troubles > with spaces. > > During a transition period we could keep accepting --substitute-urls. I require a way to clear the list of substitute urls, because last I checked --no-substitutes doesn't fully inhibit use of the substitute servers. For example, I found that when grafting, substitute servers were queried even when --no-substitutes is passed to the daemon. I guess that's to determine the set of references found in the build outputs, to optimize the grafting process. However, a compromised substitute server (or a man-in-the-middle in possession of our signing key) could send me the wrong set of references, and thus cause my system to perform incomplete grafts, with some dependencies omitted from the list of rewrites. My current method to avoid trusting the substitute servers is to pass both --no-substitutes and --substitute-urls "" to the daemon. If we deprecate the use of --substitute-urls, how will I clear the list? Mark ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS 2017-12-23 3:36 ` Mark H Weaver @ 2017-12-23 14:14 ` Ludovic Courtès 0 siblings, 0 replies; 5+ messages in thread From: Ludovic Courtès @ 2017-12-23 14:14 UTC (permalink / raw) To: Mark H Weaver; +Cc: 29814 Mark H Weaver <mhw@netris.org> skribis: > ludo@gnu.org (Ludovic Courtès) writes: [...] >> Yes, this is annoying. I think --substitute-urls (plural) was >> misguided. Instead we should instead have --substitute-url (singular), >> which could be repeated several times. That would solve the troubles >> with spaces. >> >> During a transition period we could keep accepting --substitute-urls. > > I require a way to clear the list of substitute urls, because last I > checked --no-substitutes doesn't fully inhibit use of the substitute > servers. For example, I found that when grafting, substitute servers > were queried even when --no-substitutes is passed to the daemon. I > guess that's to determine the set of references found in the build > outputs, to optimize the grafting process. However, a compromised > substitute server (or a man-in-the-middle in possession of our signing > key) could send me the wrong set of references, and thus cause my system > to perform incomplete grafts, with some dependencies omitted from the > list of rewrites. AFAIK when ‘guix-daemon --no-substitutes’ is running what you describe is impossible. If the impossible happens, could you report a bug? > My current method to avoid trusting the substitute servers is to pass > both --no-substitutes and --substitute-urls "" to the daemon. If we > deprecate the use of --substitute-urls, how will I clear the list? Normally, both for the daemon and for clients, --no-substitutes should achieve what you want. If not, we should really fix it. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS 2017-12-22 21:06 ` Ludovic Courtès 2017-12-23 3:36 ` Mark H Weaver @ 2017-12-27 16:37 ` Martin Castillo 1 sibling, 0 replies; 5+ messages in thread From: Martin Castillo @ 2017-12-27 16:37 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 29814 > Yes, this is annoying. I think --substitute-urls (plural) was > misguided. Instead we should instead have --substitute-url (singular), > which could be repeated several times. That would solve the troubles > with spaces. > > During a transition period we could keep accepting --substitute-urls. > > WDYT? Sounds good. -- GPG: 7FDE 7190 2F73 2C50 236E 403D CC13 48F1 E644 08EC ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-27 16:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-22 17:58 bug#29814: impossible to pass spaces in GUIX_BUILD_OPTIONS Martin Castillo 2017-12-22 21:06 ` Ludovic Courtès 2017-12-23 3:36 ` Mark H Weaver 2017-12-23 14:14 ` Ludovic Courtès 2017-12-27 16:37 ` Martin Castillo
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).