bug#54893: guix-daemon, locale, LANG, and unicode in git tag names

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]

Attila Lendvai schreef op di 12-04-2022 om 19:47 [+0000]:
> and i can't get rid of this^ warning. i installed glibc-locales to
> root and my user, reconfigured, restarted the guix-daemon.
> 
> which is probably the cause of the ultimate error:
> 
> warning: failed to delete .git/refs/tags/v??.2.0: No such file or
> directory
> r:sha256 hash mismatch for...
> 
> the daemon starts from an empty env:
> 
> https://git.savannah.gnu.org/cgit/guix.git/tree/nix/libstore/build.cc#n1590
> 
> and then copies the env from the derivation, but it doesn't seem to
> contain any LANG value. i assume guile is also launched then without
> a LANG env. BTW, guile could be more informative in its warning, too.

Some remarks:

  * LANG should be set, because it is in #:leaked-env-vars (see
    guix/git-download.scm).  I don't know whose LANG it is though
    -- the user's, or the daemon's?

  * To install an UTF-8 locale, you need glibc-locales (or possibly
    glibc-utf8-locales)  (At least, for now.  Upstream has some plans
    for including a C.UTF-8 locale so maybe eventually we can fallback
    to C.UTF-8.)

  * This locale data needs to be in $GUIX_LOCPATH.

  * GUIX_LOCPATH is not leaked.

  * Even if it was, I don't think that /gnu/store/...glibc-locales
    would be accessible from the build container (though you could give
    it a try?).

  * So perhaps GUIX_LOCPATH needs to be set in the gexp in
    guix/git-download.scm, + some setlocale as done by
    gnu-build-system.

  * Long-term, it could be interesting to remove the
    ‘file name = string encoded in current locale's encoding’
    assumption from Guile.

  * svn-download, hg-download, bzr-download and cvs-download
    probably have the same issue.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]