From: "Ludovic Courtès" <ludo@gnu.org>
To: Attila Lendvai <attila@lendvai.name>
Cc: 54893-done@debbugs.gnu.org
Subject: bug#54893: guix-daemon, locale, LANG, and unicode in git tag names
Date: Thu, 21 Apr 2022 00:15:28 +0200 [thread overview]
Message-ID: <87sfq7l7un.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220419180954.9636-1-attila@lendvai.name> (Attila Lendvai's message of "Tue, 19 Apr 2022 20:09:55 +0200")
Attila Lendvai <attila@lendvai.name> skribis:
> Without this the git-fetch GEXP is run in an environment that uses ASCII
> character encoding when strings are crossing the Guile - C boundary. It means
> that e.g. tag names that have Unicode chars in them will cause problems,
> e.g. when walking and deleting the .git directory.
>
> An example in the wild: https://github.com/klauspost/pgzip/tags
>
> For more details see: https://issues.guix.gnu.org/54893
>
> * guix/git-download.scm (git-fetch): Call setlocale to set it to en_US.utf8.
I spoke a bit too fast and realized some adjustments were needed to
avoid a circular dependency on i586-gnu. Pushed as
8852f911ff506dd50b714274ba0e2143f0285f78!
Ludo’.
prev parent reply other threads:[~2022-04-20 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 19:47 bug#54893: guix-daemon, locale, LANG, and unicode in git tag names Attila Lendvai
2022-04-12 20:40 ` Maxime Devos
2022-04-13 7:51 ` Attila Lendvai
2022-04-13 8:03 ` Maxime Devos
2022-04-13 8:45 ` Attila Lendvai
2022-04-19 11:38 ` Attila Lendvai
2022-04-19 15:45 ` Maxime Devos
2022-04-19 16:07 ` Maxime Devos
2022-04-13 8:22 ` Maxime Devos
2022-04-13 10:40 ` Liliana Marie Prikler
2022-04-13 10:57 ` Maxime Devos
2022-04-13 8:29 ` Maxime Devos
2022-04-19 18:09 ` bug#54893: [PATCH] guix: git-download: Set locale to deal with Unicode in git metadata Attila Lendvai
2022-04-20 20:12 ` bug#54893: guix-daemon, locale, LANG, and unicode in git tag names Ludovic Courtès
2022-04-20 22:15 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfq7l7un.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54893-done@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).