unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#58337: guile-build-system does not recognise and pass on #:tests?
@ 2022-10-06 16:14 Maxime Devos
  2022-10-07 19:19 ` Maxime Devos
  2022-10-07 20:54 ` Maxime Devos
  0 siblings, 2 replies; 3+ messages in thread
From: Maxime Devos @ 2022-10-06 16:14 UTC (permalink / raw)
  To: 58337


[-- Attachment #1.1.1: Type: text/plain, Size: 395 bytes --]

See Subject.

Not doing so would be reasonable, as there is no check phase anyway, 
however, packages using guile-build-system can define their own check 
phase that should respect #:tests?, but currently they can't, as 
#:tests? is always unset and hence (when tests? ...) is never run.
(I would give an example, but it's not in Guix yet.)

Patch to be written.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#58337: guile-build-system does not recognise and pass on #:tests?
  2022-10-06 16:14 bug#58337: guile-build-system does not recognise and pass on #:tests? Maxime Devos
@ 2022-10-07 19:19 ` Maxime Devos
  2022-10-07 20:54 ` Maxime Devos
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Devos @ 2022-10-07 19:19 UTC (permalink / raw)
  To: 58337


[-- Attachment #1.1.1: Type: text/plain, Size: 124 bytes --]

Patch(es) are in theory ready; doing some additional testing (not tested 
on in-tree guile-build-system packages yet) ...

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#58337: guile-build-system does not recognise and pass on #:tests?
  2022-10-06 16:14 bug#58337: guile-build-system does not recognise and pass on #:tests? Maxime Devos
  2022-10-07 19:19 ` Maxime Devos
@ 2022-10-07 20:54 ` Maxime Devos
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Devos @ 2022-10-07 20:54 UTC (permalink / raw)
  To: 58337


[-- Attachment #1.1.1: Type: text/plain, Size: 48 bytes --]

Fixed by: <https://issues.guix.gnu.org/58337>.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-07 20:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 16:14 bug#58337: guile-build-system does not recognise and pass on #:tests? Maxime Devos
2022-10-07 19:19 ` Maxime Devos
2022-10-07 20:54 ` Maxime Devos

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).